diff options
| author | Matthieu Baerts (NGI0) <matttbe@kernel.org> | 2025-02-24 19:11:52 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-03-22 12:56:51 -0700 |
| commit | f36e8319277dcabc353690b0af961af0d9122fc7 (patch) | |
| tree | 52a1591ed13db871ec6041358de66a4eb45bf641 /net | |
| parent | f6e0be41610b12a54b2021cf1279776f477b2b73 (diff) | |
| download | linux-f36e8319277dcabc353690b0af961af0d9122fc7.tar.gz linux-f36e8319277dcabc353690b0af961af0d9122fc7.tar.bz2 linux-f36e8319277dcabc353690b0af961af0d9122fc7.zip | |
mptcp: safety check before fallback
[ Upstream commit db75a16813aabae3b78c06b1b99f5e314c1f55d3 ]
Recently, some fallback have been initiated, while the connection was
not supposed to fallback.
Add a safety check with a warning to detect when an wrong attempt to
fallback is being done. This should help detecting any future issues
quicker.
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://patch.msgid.link/20250224-net-mptcp-misc-fixes-v1-3-f550f636b435@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'net')
| -rw-r--r-- | net/mptcp/protocol.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/net/mptcp/protocol.h b/net/mptcp/protocol.h index b70a303e0828..7e2f70f22b05 100644 --- a/net/mptcp/protocol.h +++ b/net/mptcp/protocol.h @@ -1194,6 +1194,8 @@ static inline void __mptcp_do_fallback(struct mptcp_sock *msk) pr_debug("TCP fallback already done (msk=%p)\n", msk); return; } + if (WARN_ON_ONCE(!READ_ONCE(msk->allow_infinite_fallback))) + return; set_bit(MPTCP_FALLBACK_DONE, &msk->flags); } |