diff options
| author | Eric Dumazet <edumazet@google.com> | 2025-02-07 13:58:33 +0000 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2025-02-10 18:09:09 -0800 |
| commit | 48145a57d4bbe3496e8e4880b23ea6b511e6e519 (patch) | |
| tree | 748642bf3508757ff03806f0c62751c21cdcc3f6 /net | |
| parent | cb6cc8ed77177c7553c2f8ac8605d32de58f43ac (diff) | |
| download | linux-48145a57d4bbe3496e8e4880b23ea6b511e6e519.tar.gz linux-48145a57d4bbe3496e8e4880b23ea6b511e6e519.tar.bz2 linux-48145a57d4bbe3496e8e4880b23ea6b511e6e519.zip | |
ndisc: ndisc_send_redirect() must use dev_get_by_index_rcu()
ndisc_send_redirect() is called under RCU protection, not RTNL.
It must use dev_get_by_index_rcu() instead of __dev_get_by_index()
Fixes: 2f17becfbea5 ("vrf: check the original netdevice for generating redirect")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Stephen Suryaputra <ssuryaextr@gmail.com>
Reviewed-by: David Ahern <dsahern@kernel.org>
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Link: https://patch.msgid.link/20250207135841.1948589-2-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net')
| -rw-r--r-- | net/ipv6/ndisc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c index d044c67019de..264b10a94757 100644 --- a/net/ipv6/ndisc.c +++ b/net/ipv6/ndisc.c @@ -1694,7 +1694,7 @@ void ndisc_send_redirect(struct sk_buff *skb, const struct in6_addr *target) bool ret; if (netif_is_l3_master(skb->dev)) { - dev = __dev_get_by_index(dev_net(skb->dev), IPCB(skb)->iif); + dev = dev_get_by_index_rcu(dev_net(skb->dev), IPCB(skb)->iif); if (!dev) return; } |