diff options
| author | Ignat Korchagin <ignat@cloudflare.com> | 2024-10-14 16:38:03 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-12-14 20:00:04 +0100 |
| commit | db207d19adbac96058685f6257720906ad41d215 (patch) | |
| tree | 43a48efcfe879c4fc9b9e1ea96e1860b2f089c26 /net | |
| parent | 6021ccc2471b7b95e29b7cfc7938e042bf56e281 (diff) | |
| download | linux-db207d19adbac96058685f6257720906ad41d215.tar.gz linux-db207d19adbac96058685f6257720906ad41d215.tar.bz2 linux-db207d19adbac96058685f6257720906ad41d215.zip | |
net: af_can: do not leave a dangling sk pointer in can_create()
[ Upstream commit 811a7ca7320c062e15d0f5b171fe6ad8592d1434 ]
On error can_create() frees the allocated sk object, but sock_init_data()
has already attached it to the provided sock object. This will leave a
dangling sk pointer in the sock object and may cause use-after-free later.
Signed-off-by: Ignat Korchagin <ignat@cloudflare.com>
Reviewed-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Reviewed-by: Marc Kleine-Budde <mkl@pengutronix.de>
Link: https://patch.msgid.link/20241014153808.51894-5-ignat@cloudflare.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'net')
| -rw-r--r-- | net/can/af_can.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/can/af_can.c b/net/can/af_can.c index 7343fd487dbe..c469fc187f0c 100644 --- a/net/can/af_can.c +++ b/net/can/af_can.c @@ -171,6 +171,7 @@ static int can_create(struct net *net, struct socket *sock, int protocol, /* release sk on errors */ sock_orphan(sk); sock_put(sk); + sock->sk = NULL; } errout: |