diff options
| author | Zhu Jun <zhujun2@cmss.chinamobile.com> | 2024-10-09 18:41:26 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-12-14 19:51:36 +0100 |
| commit | 8e9f76ddc20cf801ed8434c6b6c8063830b9a0a2 (patch) | |
| tree | cea836068cd683932ccefb5c89f5e9157e54a769 /samples | |
| parent | 3caa244323a6301359d8570046faf7a1514bcdf7 (diff) | |
| download | linux-8e9f76ddc20cf801ed8434c6b6c8063830b9a0a2.tar.gz linux-8e9f76ddc20cf801ed8434c6b6c8063830b9a0a2.tar.bz2 linux-8e9f76ddc20cf801ed8434c6b6c8063830b9a0a2.zip | |
samples/bpf: Fix a resource leak
[ Upstream commit f3ef53174b23246fe9bc2bbc2542f3a3856fa1e2 ]
The opened file should be closed in show_sockopts(), otherwise resource
leak will occur that this problem was discovered by reading code
Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/20241010014126.2573-1-zhujun2@cmss.chinamobile.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'samples')
| -rw-r--r-- | samples/bpf/test_cgrp2_sock.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/samples/bpf/test_cgrp2_sock.c b/samples/bpf/test_cgrp2_sock.c index b0811da5a00f..3f56519a1ccd 100644 --- a/samples/bpf/test_cgrp2_sock.c +++ b/samples/bpf/test_cgrp2_sock.c @@ -174,8 +174,10 @@ static int show_sockopts(int family) return 1; } - if (get_bind_to_device(sd, name, sizeof(name)) < 0) + if (get_bind_to_device(sd, name, sizeof(name)) < 0) { + close(sd); return 1; + } mark = get_somark(sd); prio = get_priority(sd); |