diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2020-07-23 18:22:19 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-08-21 11:02:02 +0200 |
| commit | 5edf79a812a0a2e03a5433b19cb63caffb0b1836 (patch) | |
| tree | ead42f5968ba8f0c461aeac577ad90fdb0597ac2 /security | |
| parent | 6bd5aeb62401126e3aa3e8596a5ffc81776289e1 (diff) | |
| download | linux-5edf79a812a0a2e03a5433b19cb63caffb0b1836.tar.gz linux-5edf79a812a0a2e03a5433b19cb63caffb0b1836.tar.bz2 linux-5edf79a812a0a2e03a5433b19cb63caffb0b1836.zip | |
Smack: fix another vsscanf out of bounds
[ Upstream commit a6bd4f6d9b07452b0b19842044a6c3ea384b0b88 ]
This is similar to commit 84e99e58e8d1 ("Smack: slab-out-of-bounds in
vsscanf") where we added a bounds check on "rule".
Reported-by: syzbot+a22c6092d003d6fe1122@syzkaller.appspotmail.com
Fixes: f7112e6c9abf ("Smack: allow for significantly longer Smack labels v4")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'security')
| -rw-r--r-- | security/smack/smackfs.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c index 2bfec47b8d5c..2eba7c1e6663 100644 --- a/security/smack/smackfs.c +++ b/security/smack/smackfs.c @@ -928,6 +928,10 @@ static ssize_t smk_set_cipso(struct file *file, const char __user *buf, for (i = 0; i < catlen; i++) { rule += SMK_DIGITLEN; + if (rule > data + count) { + rc = -EOVERFLOW; + goto out; + } ret = sscanf(rule, "%u", &cat); if (ret != 1 || cat > SMACK_CIPSO_MAXCATNUM) goto out; |