diff options
| author | Breno Leitao <leitao@debian.org> | 2024-11-21 01:57:12 -0800 |
|---|---|---|
| committer | Mimi Zohar <zohar@linux.ibm.com> | 2024-12-24 13:56:45 -0500 |
| commit | 68af44a71975688b881ea524e2526bb7c7ad0e9a (patch) | |
| tree | edb47ac4ac202e17e9cd860d51961c3ecabd7d17 /security | |
| parent | 254ef9541d68bd9d75296b2487ec97d4d6d40d57 (diff) | |
| download | linux-68af44a71975688b881ea524e2526bb7c7ad0e9a.tar.gz linux-68af44a71975688b881ea524e2526bb7c7ad0e9a.tar.bz2 linux-68af44a71975688b881ea524e2526bb7c7ad0e9a.zip | |
ima: kexec: silence RCU list traversal warning
The ima_measurements list is append-only and doesn't require
rcu_read_lock() protection. However, lockdep issues a warning when
traversing RCU lists without the read lock:
security/integrity/ima/ima_kexec.c:40 RCU-list traversed in non-reader section!!
Fix this by using the variant of list_for_each_entry_rcu() with the last
argument set to true. This tells the RCU subsystem that traversing this
append-only list without the read lock is intentional and safe.
This change silences the lockdep warning while maintaining the correct
semantics for the append-only list traversal.
Signed-off-by: Breno Leitao <leitao@debian.org>
Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
Diffstat (limited to 'security')
| -rw-r--r-- | security/integrity/ima/ima_kexec.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/security/integrity/ima/ima_kexec.c b/security/integrity/ima/ima_kexec.c index 52e00332defe..9d45f4d26f73 100644 --- a/security/integrity/ima/ima_kexec.c +++ b/security/integrity/ima/ima_kexec.c @@ -37,7 +37,8 @@ static int ima_dump_measurement_list(unsigned long *buffer_size, void **buffer, memset(&khdr, 0, sizeof(khdr)); khdr.version = 1; - list_for_each_entry_rcu(qe, &ima_measurements, later) { + /* This is an append-only list, no need to hold the RCU read lock */ + list_for_each_entry_rcu(qe, &ima_measurements, later, true) { if (file.count < file.size) { khdr.count++; ima_measurements_show(&file, qe); |