summaryrefslogtreecommitdiff
path: root/sound/usb
diff options
context:
space:
mode:
authorZhu Jun <zhujun2@cmss.chinamobile.com>2024-10-09 00:09:44 -0700
committerTakashi Iwai <tiwai@suse.de>2024-10-10 14:23:01 +0200
commit0845b3e0d5c1a8ddf2056a0f2672ddf769dc446c (patch)
tree3bef56367e048bdcc8848a6056cb10adb910a5e6 /sound/usb
parent0498a04e399c6e720bb991db992174e19b2fe980 (diff)
downloadlinux-0845b3e0d5c1a8ddf2056a0f2672ddf769dc446c.tar.gz
linux-0845b3e0d5c1a8ddf2056a0f2672ddf769dc446c.tar.bz2
linux-0845b3e0d5c1a8ddf2056a0f2672ddf769dc446c.zip
ALSA: usb-audio: Use snprintf instead of sprintf in build_mixer_unit_ctl
Simplified code by removing redundant assignment of sprintf return value and improved safety by replacing sprintf with snprintf. Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com> Link: https://patch.msgid.link/20241009070944.6937-1-zhujun2@cmss.chinamobile.com Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/usb')
-rw-r--r--sound/usb/mixer.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c
index 9945ae55b0d0..b6c3d2ee416e 100644
--- a/sound/usb/mixer.c
+++ b/sound/usb/mixer.c
@@ -2224,7 +2224,8 @@ static void build_mixer_unit_ctl(struct mixer_build *state,
len = get_term_name(state->chip, iterm, kctl->id.name,
sizeof(kctl->id.name), 0);
if (!len)
- len = sprintf(kctl->id.name, "Mixer Source %d", in_ch + 1);
+ snprintf(kctl->id.name, sizeof(kctl->id.name), "Mixer Source %d", in_ch + 1);
+
append_ctl_name(kctl, " Volume");
usb_audio_dbg(state->chip, "[%d] MU [%s] ch = %d, val = %d/%d\n",