summaryrefslogtreecommitdiff
path: root/sound
diff options
context:
space:
mode:
authortangbin <tangbin@cmss.chinamobile.com>2024-09-03 17:06:20 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2024-10-04 16:29:05 +0200
commitf606b9ac4abbe56816eee1941dccae9b6d3d8952 (patch)
treee67eeea487136e12bfa43da010a2647dd6124c84 /sound
parent886ea81de41f7ee04dc5e0cfc54037df2769ce8c (diff)
downloadlinux-f606b9ac4abbe56816eee1941dccae9b6d3d8952.tar.gz
linux-f606b9ac4abbe56816eee1941dccae9b6d3d8952.tar.bz2
linux-f606b9ac4abbe56816eee1941dccae9b6d3d8952.zip
ASoC: loongson: fix error release
[ Upstream commit 97688a9c5b1fd2b826c682cdfa36d411a5c99828 ] In function loongson_card_parse_of(), when get device_node 'codec' failed, the function of_node_put(codec) should not be invoked, thus fix error release. Fixes: d24028606e76 ("ASoC: loongson: Add Loongson ASoC Sound Card Support") Signed-off-by: tangbin <tangbin@cmss.chinamobile.com> Link: https://patch.msgid.link/20240903090620.6276-1-tangbin@cmss.chinamobile.com Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'sound')
-rw-r--r--sound/soc/loongson/loongson_card.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/sound/soc/loongson/loongson_card.c b/sound/soc/loongson/loongson_card.c
index 406ee8db1a3c..8cc54aedd002 100644
--- a/sound/soc/loongson/loongson_card.c
+++ b/sound/soc/loongson/loongson_card.c
@@ -127,8 +127,8 @@ static int loongson_card_parse_of(struct loongson_card_data *data)
codec = of_get_child_by_name(dev->of_node, "codec");
if (!codec) {
dev_err(dev, "audio-codec property missing or invalid\n");
- ret = -EINVAL;
- goto err;
+ of_node_put(cpu);
+ return -EINVAL;
}
for (i = 0; i < card->num_links; i++) {