diff options
| author | Ian Rogers <irogers@google.com> | 2025-02-28 14:22:58 -0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-04-10 14:44:31 +0200 |
| commit | a4c70eb0502dca4a3027645f6e694afb407643b0 (patch) | |
| tree | 91fa867aaeee02f5ab00e0dff01873fe65d2046d /tools/perf | |
| parent | 9c40a68b7f97fa487e6c7e67fcf4f846a1f96692 (diff) | |
| download | linux-a4c70eb0502dca4a3027645f6e694afb407643b0.tar.gz linux-a4c70eb0502dca4a3027645f6e694afb407643b0.tar.bz2 linux-a4c70eb0502dca4a3027645f6e694afb407643b0.zip | |
perf debug: Avoid stack overflow in recursive error message
[ Upstream commit bda840191d2aae3b7cadc3ac21835dcf29487191 ]
In debug_file, pr_warning_once is called on error. As that function
calls debug_file the function will yield a stack overflow. Switch the
location of the call so the recursion is avoided.
Reviewed-by: Howard Chu <howardchu95@gmail.com>
Signed-off-by: Ian Rogers <irogers@google.com>
Reviewed-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Link: https://lore.kernel.org/r/20250228222308.626803-2-irogers@google.com
Fixes: ec49230cf6dda704 ("perf debug: Expose debug file")
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'tools/perf')
| -rw-r--r-- | tools/perf/util/debug.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/perf/util/debug.c b/tools/perf/util/debug.c index 995f6bb05b5f..f9ef7d045c92 100644 --- a/tools/perf/util/debug.c +++ b/tools/perf/util/debug.c @@ -46,8 +46,8 @@ int debug_type_profile; FILE *debug_file(void) { if (!_debug_file) { - pr_warning_once("debug_file not set"); debug_set_file(stderr); + pr_warning_once("debug_file not set"); } return _debug_file; } |