diff options
| author | Nicolas Frattaroli <nicolas.frattaroli@collabora.com> | 2025-02-21 21:39:32 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-03-22 12:56:51 -0700 |
| commit | 31ccfd2289d3f032806fd7cd4c5c5370e144fae5 (patch) | |
| tree | 6f35ba4c3d81e01d724644e0baaa5221b743f1e5 /tools/sound | |
| parent | d9529db53477f33e3b448fcf0df42c3397d6e27e (diff) | |
| download | linux-31ccfd2289d3f032806fd7cd4c5c5370e144fae5.tar.gz linux-31ccfd2289d3f032806fd7cd4c5c5370e144fae5.tar.bz2 linux-31ccfd2289d3f032806fd7cd4c5c5370e144fae5.zip | |
ASoC: dapm-graph: set fill colour of turned on nodes
[ Upstream commit d31babd7e304d3b800d36ff74be6739405b985f2 ]
Some tools like KGraphViewer interpret the "ON" nodes not having an
explicitly set fill colour as them being entirely black, which obscures
the text on them and looks funny. In fact, I thought they were off for
the longest time. Comparing to the output of the `dot` tool, I assume
they are supposed to be white.
Instead of speclawyering over who's in the wrong and must immediately
atone for their wickedness at the altar of RFC2119, just be explicit
about it, set the fillcolor to white, and nobody gets confused.
Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Tested-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Link: https://patch.msgid.link/20250221-dapm-graph-node-colour-v1-1-514ed0aa7069@collabora.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'tools/sound')
| -rwxr-xr-x | tools/sound/dapm-graph | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/sound/dapm-graph b/tools/sound/dapm-graph index f14bdfedee8f..b6196ee5065a 100755 --- a/tools/sound/dapm-graph +++ b/tools/sound/dapm-graph @@ -10,7 +10,7 @@ set -eu STYLE_COMPONENT_ON="color=dodgerblue;style=bold" STYLE_COMPONENT_OFF="color=gray40;style=filled;fillcolor=gray90" -STYLE_NODE_ON="shape=box,style=bold,color=green4" +STYLE_NODE_ON="shape=box,style=bold,color=green4,fillcolor=white" STYLE_NODE_OFF="shape=box,style=filled,color=gray30,fillcolor=gray95" # Print usage and exit |