diff options
| author | Mika Westerberg <mika.westerberg@linux.intel.com> | 2022-10-28 09:27:50 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-12-31 13:32:44 +0100 |
| commit | 0fd13791feb649c2e0e5c855eaf7c07864535578 (patch) | |
| tree | a5973e564f5b61bb38981800e1bb273b0b109c78 /tools | |
| parent | a9b65ba1afcc9dbdcd786c3a7a13452fdb9b5fd8 (diff) | |
| download | linux-0fd13791feb649c2e0e5c855eaf7c07864535578.tar.gz linux-0fd13791feb649c2e0e5c855eaf7c07864535578.tar.bz2 linux-0fd13791feb649c2e0e5c855eaf7c07864535578.zip | |
watchdog: iTCO_wdt: Set NO_REBOOT if the watchdog is not already running
[ Upstream commit ef9b7bf52c2f47f0a9bf988543c577b92c92d15e ]
Daniel reported that the commit 1ae3e78c0820 ("watchdog: iTCO_wdt: No
need to stop the timer in probe") makes QEMU implementation of the iTCO
watchdog not to trigger reboot anymore when NO_REBOOT flag is initially
cleared using this option (in QEMU command line):
-global ICH9-LPC.noreboot=false
The problem with the commit is that it left the unconditional setting of
NO_REBOOT that is not cleared anymore when the kernel keeps pinging the
watchdog (as opposed to the previous code that called iTCO_wdt_stop()
that cleared it).
Fix this so that we only set NO_REBOOT if the watchdog was not initially
running.
Fixes: 1ae3e78c0820 ("watchdog: iTCO_wdt: No need to stop the timer in probe")
Reported-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Tested-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20221028062750.45451-1-mika.westerberg@linux.intel.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'tools')
0 files changed, 0 insertions, 0 deletions
