diff options
| author | Josh Poimboeuf <jpoimboe@kernel.org> | 2025-03-25 18:30:37 -0700 |
|---|---|---|
| committer | Ingo Molnar <mingo@kernel.org> | 2025-03-28 14:38:09 +0100 |
| commit | d9a595c3850ea4383628115df2bb533af3b29f4f (patch) | |
| tree | 171685838add4e0a7d46bee34dcd008de46115c2 /tools | |
| parent | 05026ea01e95ffdeb0e5ac8fb7fb1b551e3a8726 (diff) | |
| download | linux-d9a595c3850ea4383628115df2bb533af3b29f4f.tar.gz linux-d9a595c3850ea4383628115df2bb533af3b29f4f.tar.bz2 linux-d9a595c3850ea4383628115df2bb533af3b29f4f.zip | |
objtool: Fix NULL printf() '%s' argument in builtin-check.c:save_argv()
It's probably not the best idea to pass a string pointer to printf()
right after confirming said pointer is NULL. Fix the typo and use
argv[i] instead.
Fixes: c5995abe1547 ("objtool: Improve error handling")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Tested-by: Stephen Rothwell <sfr@canb.auug.org.au>
Link: https://lore.kernel.org/r/a814ed8b08fb410be29498a20a5fbbb26e907ecf.1742952512.git.jpoimboe@kernel.org
Closes: https://lore.kernel.org/20250326103854.309e3c60@canb.auug.org.au
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/objtool/builtin-check.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/objtool/builtin-check.c b/tools/objtool/builtin-check.c index 2bdff910430e..e364ab6345d3 100644 --- a/tools/objtool/builtin-check.c +++ b/tools/objtool/builtin-check.c @@ -238,7 +238,7 @@ static void save_argv(int argc, const char **argv) for (int i = 0; i < argc; i++) { orig_argv[i] = strdup(argv[i]); if (!orig_argv[i]) { - WARN_GLIBC("strdup(%s)", orig_argv[i]); + WARN_GLIBC("strdup(%s)", argv[i]); exit(1); } }; |