summaryrefslogtreecommitdiff
path: root/virt
diff options
context:
space:
mode:
authorSean Christopherson <seanjc@google.com>2025-05-16 16:07:31 -0700
committerSean Christopherson <seanjc@google.com>2025-06-20 13:52:39 -0700
commit5d7dbdce388b43cf3a9bc50c4132493de26aeba4 (patch)
treecf4356305c6e1857dd67a80f090ed5dda5400d65 /virt
parentadd57f493e0893ac0fb4acbdc441918d3e800f10 (diff)
downloadlinux-5d7dbdce388b43cf3a9bc50c4132493de26aeba4.tar.gz
linux-5d7dbdce388b43cf3a9bc50c4132493de26aeba4.tar.bz2
linux-5d7dbdce388b43cf3a9bc50c4132493de26aeba4.zip
irqbypass: Use paired consumer/producer to disconnect during unregister
Use the paired consumer/producer information to disconnect IRQ bypass producers/consumers in O(1) time (ignoring the cost of __disconnect()). Reviewed-by: Kevin Tian <kevin.tian@intel.com> Acked-by: Michael S. Tsirkin <mst@redhat.com> Reviewed-by: Alex Williamson <alex.williamson@redhat.com> Link: https://lore.kernel.org/r/20250516230734.2564775-6-seanjc@google.com Signed-off-by: Sean Christopherson <seanjc@google.com>
Diffstat (limited to 'virt')
-rw-r--r--virt/lib/irqbypass.c48
1 files changed, 8 insertions, 40 deletions
diff --git a/virt/lib/irqbypass.c b/virt/lib/irqbypass.c
index fdbf7ecc0c21..6a183459dc44 100644
--- a/virt/lib/irqbypass.c
+++ b/virt/lib/irqbypass.c
@@ -138,32 +138,16 @@ EXPORT_SYMBOL_GPL(irq_bypass_register_producer);
*/
void irq_bypass_unregister_producer(struct irq_bypass_producer *producer)
{
- struct irq_bypass_producer *tmp;
- struct irq_bypass_consumer *consumer;
-
if (!producer->eventfd)
return;
mutex_lock(&lock);
- list_for_each_entry(tmp, &producers, node) {
- if (tmp->eventfd != producer->eventfd)
- continue;
-
- list_for_each_entry(consumer, &consumers, node) {
- if (consumer->eventfd == producer->eventfd) {
- WARN_ON_ONCE(producer->consumer != consumer);
- __disconnect(producer, consumer);
- break;
- }
- }
-
- producer->eventfd = NULL;
- list_del(&producer->node);
- break;
- }
+ if (producer->consumer)
+ __disconnect(producer, producer->consumer);
- WARN_ON_ONCE(producer->eventfd);
+ producer->eventfd = NULL;
+ list_del(&producer->node);
mutex_unlock(&lock);
}
EXPORT_SYMBOL_GPL(irq_bypass_unregister_producer);
@@ -228,32 +212,16 @@ EXPORT_SYMBOL_GPL(irq_bypass_register_consumer);
*/
void irq_bypass_unregister_consumer(struct irq_bypass_consumer *consumer)
{
- struct irq_bypass_consumer *tmp;
- struct irq_bypass_producer *producer;
-
if (!consumer->eventfd)
return;
mutex_lock(&lock);
- list_for_each_entry(tmp, &consumers, node) {
- if (tmp != consumer)
- continue;
-
- list_for_each_entry(producer, &producers, node) {
- if (producer->eventfd == consumer->eventfd) {
- WARN_ON_ONCE(consumer->producer != producer);
- __disconnect(producer, consumer);
- break;
- }
- }
-
- consumer->eventfd = NULL;
- list_del(&consumer->node);
- break;
- }
+ if (consumer->producer)
+ __disconnect(consumer->producer, consumer);
- WARN_ON_ONCE(consumer->eventfd);
+ consumer->eventfd = NULL;
+ list_del(&consumer->node);
mutex_unlock(&lock);
}
EXPORT_SYMBOL_GPL(irq_bypass_unregister_consumer);