samba.git, branch tdb-1.3.1

tdb: change version to 1.3.1

2014-09-16T10:13:31+00:00

* internal code cleanup
* improved free record detection with a highly contended freelist
  on tdb's with dead record support (TDB_VOLATILE).
* implicit defragmentation of the free list.

Signed-off-by: Michael Adam 
Reviewed-by: Stefan Metzmacher 

Autobuild-User(master): Stefan Metzmacher 
Autobuild-Date(master): Tue Sep 16 12:13:31 CEST 2014 on sn-devel-104

tdb:tools: fix a compiler warning

2014-09-16T07:47:05+00:00

   ../../tdb/tools/tdbtool.c: In function ‘do_command’:
   ../../tdb/tools/tdbtool.c:717: error: declaration of ‘count’ shadows a global declaration
   ../../tdb/tools/tdbtool.c:597: error: shadowed declaration is here

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Stefan Metzmacher

Add test suite for iconv conversion fail of bad names over SMB1/SMB3.

2014-09-16T02:21:49+00:00

Bug 10775 - smbd crashes when accessing garbage filenames

https://bugzilla.samba.org/show_bug.cgi?id=10775

Signed-off-by: Jeremy Allison 
Reviewed-by: David Disseldorp 

Autobuild-User(master): David Disseldorp 
Autobuild-Date(master): Tue Sep 16 04:21:49 CEST 2014 on sn-devel-104

s3: smbd: Fix a couple of tricky slow-path cases - don't return a mangled name for a name that cannot be converted.

2014-09-15T23:56:55+00:00

For a name that contains an illegal Windows character, the
directory listing code returns the mangled 8.3 name as the
primary name for the file.

If the original (non-mangled) filename cannot be converted
to UCS2 on the wire via iconv due to conversion error, we
should skip that name when returning a directory listing,
as we can't map back from a returned 8.3 name to a usable
non-mangled filename if the client sends it back to us.

As this is only done in a very slow path (name must be mangled)
or in the old DOS protocol listing code I don't feel too bad
about using a talloc/free pair here.

Bug 10775 - smbd crashes when accessing garbage filenames

https://bugzilla.samba.org/show_bug.cgi?id=10775

Signed-off-by: Jeremy Allison 
Reviewed-by: David Disseldorp

s3: smbd: Change get_lanman2_dir_entry() to return the full NTSTATUS.

2014-09-15T23:56:55+00:00

Handle the errors correctly at the level above inside the SMB1 server.

Bug 10775 - smbd crashes when accessing garbage filenames

https://bugzilla.samba.org/show_bug.cgi?id=10775

Signed-off-by: Jeremy Allison 
Reviewed-by: David Disseldorp

s3: smbd: Remove unneeded 'out_of_space' parameter from smbd_dirptr_lanman2_entry().

2014-09-15T23:56:55+00:00

This can now be handled by checking for the STATUS_MORE_ENTRIES error return.

Bug 10775 - smbd crashes when accessing garbage filenames

https://bugzilla.samba.org/show_bug.cgi?id=10775

Signed-off-by: Jeremy Allison 
Reviewed-by: David Disseldorp

s3: smbd: SMB2 - change smbd_dirptr_lanman2_entry() to return an NTSTATUS.

2014-09-15T23:56:55+00:00

Handle the errors correctly at the top level inside the SMB2 server.

Bug 10775 - smbd crashes when accessing garbage filenames

https://bugzilla.samba.org/show_bug.cgi?id=10775

Signed-off-by: Jeremy Allison 
Reviewed-by: David Disseldorp

s3: smbd: smbd_marshall_dir_entry() no longer needs explicit 'out_of_space' parameter.

2014-09-15T23:56:54+00:00

Handle this in the caller when it returns STATUS_MORE_ENTRIES.

Bug 10775 - smbd crashes when accessing garbage filenames

https://bugzilla.samba.org/show_bug.cgi?id=10775

Signed-off-by: Jeremy Allison 
Reviewed-by: David Disseldorp

s3: smbd: Change smbd_marshall_dir_entry() to return an NTSTATUS. Returns STATUS_MORE_ENTRIES on out of space.

2014-09-15T23:56:54+00:00

Bug 10775 - smbd crashes when accessing garbage filenames

https://bugzilla.samba.org/show_bug.cgi?id=10775

Signed-off-by: Jeremy Allison 
Reviewed-by: David Disseldorp

s3: smbd: Change the function signature of srvstr_push() from returning a length to returning an NTSTATUS with a length param.

2014-09-15T23:56:54+00:00

srvstr_push_fn() now returns an NTSTATUS reporting any
string conversion failure.

We need to get serious about returning character set conversion errors
inside smbd.

Bug 10775 - smbd crashes when accessing garbage filenames

https://bugzilla.samba.org/show_bug.cgi?id=10775

Signed-off-by: Jeremy Allison 
Reviewed-by: David Disseldorp