samba.git/auth, branch talloc-2.3.2

Revert "cli_credentials: add a helper to parse user or group names"

2020-11-05T06:30:31+00:00

This reverts commit 00f4262ed0b22f6e333e5a29c5590b62c783905c.

Revert "cli_credentials_parse_string: fix parsing of principals"

2020-11-05T06:30:31+00:00

This reverts commit eb0474d27bae4592b25ac6bf600da29c6a1cb9f8.

cli_credentials: add a helper to parse user or group names

2020-11-04T14:59:34+00:00

cli_credentials_parse_string() parses a string specified for -U option
in command line tools. It has a side-effect that '%' character is always
considered to be a separator after which a password is specified.

Active Directory does allow to create user or group objects with '%' in
the name. It means cli_credentials_parse_string() will not be able to
properly parse such name.

Introduce cli_credentials_parse_name() for the cases when a password is
not expected in the name and call to cli_credentials_parse_name() from
cli_credentials_parse_string().

Test cli_credentials_parse_name() with its intended use in lookup_name()
refactoring.

Signed-off-by: Alexander Bokovoy 
Reviewed-by: Andreas Schneider 
Reviewed-by: Stefan Metzmacher

cli_credentials_parse_string: fix parsing of principals

2020-11-04T14:59:34+00:00

When parsing a principal-like name, user name was left with full
principal instead of taking only the left part before '@' sign.

>>> from samba import credentials
>>> t = credentials.Credentials()
>>> t.parse_string('admin@realm.test', credentials.SPECIFIED)
>>> t.get_username()
'admin@realm.test'

The issue is that cli_credentials_set_username() does a talloc_strdup()
of the argument, so we need to change order of assignment to allow
talloc_strdup() to copy the right part of the string.

Signed-off-by: Alexander Bokovoy 
Reviewed-by: Andreas Schneider 
Reviewed-by: Stefan Metzmacher

auth:creds:tests: Migrate test to a cmocka unit test

2020-11-03T15:25:37+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Alexander Bokovoy

auth:creds: Rename CRED_USE_KERBEROS values

2020-11-03T15:25:37+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Alexander Bokovoy

auth:creds: Add cli_credentials_init_server()

2020-09-07T12:02:15+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Stefan Metzmacher

auth:gensec: If Kerberos is required, keep schannel for machine account auth

2020-09-07T12:02:15+00:00

Signed-off-by: Stefan Metzmacher 
Signed-off-by: Andreas Schneider

auth:gensec: Pass use_kerberos and keep_schannel to gensec_use_kerberos_mechs()

2020-09-07T12:02:15+00:00

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andreas Schneider

auth:gensec: Make gensec_use_kerberos_mechs() a static function

2020-09-07T12:02:15+00:00

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andreas Schneider