samba.git/buildtools, branch talloc-2.2.0

build: Standardise on calling conf.SAMBA_CHECK_PYTHON() in libraries

2019-03-21T04:06:16+00:00

We do this by removing the confusing mandatory option to
conf.SAMBA_CHECK_PYTHON{,_HEADERS}(), instead just use the value of
--disable-python internally

This follows the default minimum of Python 3.4 and keeps things consistent
with the main Samba build where --disable-python is required to skip building
python bindings.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

build: Set default minimum python version to 3.4.0

2019-03-21T04:06:15+00:00

This is the current minimum, but this may change before the 4.11 release.

Python 2.x support is no longer available except to build using --disable-python.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

build: Do not make python mandatory to build

2019-03-21T04:06:15+00:00

Clearly we have python or else we would not be running, so this is about if
we have a new enough version.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

build: Remove distinct .py3 ABI files

2019-03-21T04:06:15+00:00

The only difference between the two built libraries is pytalloc_CObject_FromTallocPtr()
which is deprecated.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

build: Remove bld.gen_python_environments()

2019-03-21T04:06:14+00:00

This was part of --extra-python support.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Garming Sam

build: Remove --extra-python

2019-03-21T04:06:14+00:00

This option is quite invasive in waf and was mainly for the python3 transition.

Testing with multiple python versions can be done by testing a full compile against
multiple versions, likewise multiple different binding versions can be created
the same way.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

wafbuild: create missing private library symlinks on platforms without soname support for shared libs

2019-03-01T17:05:19+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=9557

Signed-off-by: Bjoern Jacke 
Reviewed-by: Stefan Metzmacher 

Autobuild-User(master): Björn Jacke 
Autobuild-Date(master): Fri Mar  1 17:05:19 UTC 2019 on sn-devel-144

wafsamba/symbols: change regex to match both rpath and runpath for different readelf output

2019-02-18T08:25:21+00:00

In `wafsamba.dumplicate_symbols` test, it will use Popen to call:

    readelf --dynamic bin/default/source3/lib/netapi/examples/netlogon/netlogon_control2

then try to find rpath lib lines from output with regex:

    re_rpath     = re.compile(b'Library rpath: \[(.*)\]')

In ubuntu 14.04 docker image, which current CI is using, the actual output
from `readelf` is `runpath` instead of 'rpath':

    ...
    Library runpath: [/home/gitlab-runner/samba/bin/shared:/home/gitlab-runner/samba/bin/shared/private]\n'
    ...

So the regex never matched, and hide a bug.

In Ubuntu 1604 docker image, the output changes to `rpath` and matched the
regex, which expose the error in previous commit.

Improve the regex to match both `rpath` and `runpath`.

Signed-off-by: Joe Guo 
Reviewed-by: Alexander Bokovoy 
Reviewed-by: Andrew Bartlett

wafsamba/symbols: always split Popen output by bytes

2019-02-18T08:25:21+00:00

In py3, `wafsamba.duplicate_symbols` test may fail:

    ...
    elfpipe = subprocess.Popen(['readelf', '--dynamic', binname], stdout=subprocess.PIPE).stdout
    ...

    File "./buildtools/wafsamba/symbols.py", line 153, in get_libs
        rpath.extend(m.group(1).split(":"))
    TypeError: a bytes-like object is required, not 'str'

Because Popen will always return bytestr even in py3, and ":" is a
unicode str in py3.  Change ":" to b":" to fix.

Signed-off-by: Joe Guo 
Reviewed-by: Alexander Bokovoy 
Reviewed-by: Andrew Bartlett

waf: fix setting of RPATH_ST variable

2019-02-17T12:33:15+00:00

Signed-off-by: Bjoern Jacke 
Reviewed-by: Andreas Schneider