samba.git/ctdb/common, branch master

ctdb-event: Fix the build on FreeBSD

2026-03-18T11:20:37+00:00

FreeBSD does not have ENODATA.  Sorry, I wasn't thinking about
portability when I made the changes that introduced the use of ENODATA
here.  :-(

Use ENOMSG instead, for lack of anything better, to indicate a script
slot containing no result.  ENOENT might seem more appropriate but it
is already involved in this code (where it is sometimes mapped to
ENOEXEC).  The choice of error number only needs to be consistent
within the event code.

Signed-off-by: Martin Schwenke 
Reviewed-by: Anoop C S

ctdb-common: Remove unused function ctdb_set_helper()

2026-02-25T12:33:39+00:00

Signed-off-by: Martin Schwenke 
Reviewed-by: Anoop C S

ctdb-common: Add path_helperdir() and path_helperdir_append()

2026-02-25T12:33:39+00:00

These can be used to locate helpers, either during in-tree
testing (using $CTDB_TEST_HELPER_BINDIR) or in their configured
installation location.

Signed-off-by: Martin Schwenke 
Reviewed-by: Anoop C S

ctdb-common: Use if_nametoindex(3) to check if interface exists

2026-02-09T11:17:41+00:00

This is much simpler than looping through the array.  It will also
find an interface by altname, which could be very useful.

Signed-off-by: Martin Schwenke 
Reviewed-by: Volker Lendecke

ctdb-common: Align integer type

2026-02-09T11:17:41+00:00

[132/416] Compiling ctdb/common/run_event.c
../../common/run_event.c: In function ‘run_event_fail’:
../../common/run_event.c:806:50: warning: comparison of integer expressions of different signedness: ‘id_t’ {aka ‘unsigned int’} and ‘int’ [-Wsign-compare]
  806 |         if (script->summary == -ETIMEDOUT && pid != -1) {
      |                                                  ^~

This is actually due to a typo in commit
20e9f203627752c4c1934e4bc0776e26c0dfb00e.  It should always have been
pid_t.

Signed-off-by: Martin Schwenke 
Reviewed-by: Volker Lendecke

ctdb-common: Make run_event return full script list

2025-10-07T10:08:34+00:00

run_event currently truncates the resulting script list after the
first failure.

Instead, return the full script list, with scripts that weren't run
flagged with ENODATA in their summary.  This structure is zeroed on
allocation, so this is the only field that needs to be set.

For now, have the event tool skip such scripts.  Do this in
print_status() instead of print_status_one(), since there will soon be
additional checks in print_status() and it makes sense to put them
together.

Signed-off-by: Martin Schwenke 
Reviewed-by: Ralph Boehme

ctdb-common: Factor out new function run_event_fail()

2025-10-07T10:08:34+00:00

Mostly due to future indentation requirements.

Signed-off-by: Martin Schwenke 
Reviewed-by: Ralph Boehme

ctdb-common: Only respect CTDB_SOCKET in CTDB_TEST_MODE

2025-09-25T09:02:06+00:00

At the moment CTDB_SOCKET can be used outside of test mode even though
nobody should do this.  So, no longer allow this.

This means ensuring CTDB_TEST_MODE is set in the in the
"clusteredmember" selftest environment, so that CTDB_SOCKET is
respected there..

Details...

The associated use of chown(2) and chmod(2), used to secure the socket
in ctdb_daemon.c:ux_socket_bind(), potentially enables a symlink race
attack.  However, the chown(2) is currently not done in test mode, so
restricting the use of CTDB_SOCKET to test mode solves the potential
security issue.

Also, sprinkle warnings about use of CTDB_TEST_MODE in appropriate
places, just to attempt to limit unwanted behaviour.

An alternative could be to use the socket file descriptor with
fchown(2) and fchmod(2).  However, these system calls are not well
defined on sockets.  Still, this was previously done in CTDB's early
days (using the poorly documented method where they are allowed in
Linux (only?) before calling bind(2)).  It was removed (due to
portability issues, via commits
cf1056df94943ddcc3d547d4533b4bc04f57f265 and
2da3fe1b175a468fdff4aa4f65627facd2c28394) and replaced with the
current post-bind chown(2) and chmod(2).

I would like to remove the CTDB_SOCKET environment variable entirely,
since setting CTDB_TEST_MODE and CTDB_BASE covers all reasonable test
environments.  However, I have a feeling that people use it for
interactive testing, and that can still be done in CTDB_TEST_MODE.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15921

Signed-off-by: Martin Schwenke 
Reported-by: *GUIAR OQBA * 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Volker Lendecke 
Autobuild-Date(master): Thu Sep 25 09:02:06 UTC 2025 on atb-devel-224

ctdb-common: Factor out checking of CTDB_TEST_MODE

2025-09-25T07:57:42+00:00

For use elsewhere.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15921

Signed-off-by: Martin Schwenke

ctdb-common: Add tunable directory loading

2025-07-22T23:02:34+00:00

This is simpler than include files and more general than just allowing
a 2nd file to be loaded.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs