<feed xmlns='http://www.w3.org/2005/Atom'>
<title>samba.git/ctdb/ib/ibwrapper.c, branch talloc-2.3.3</title>
<subtitle>Unnamed repository; edit this file 'description' to name the repository.</subtitle>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/'/>
<entry>
<title>ctdb-ib: Fix build errors for infiniband transport</title>
<updated>2019-11-13T13:31:10+00:00</updated>
<author>
<name>Amitay Isaacs</name>
<email>amitay@gmail.com</email>
</author>
<published>2019-11-12T03:14:53+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=816205027a12d16b5de7c1fd78b4bed468a94fbb'/>
<id>816205027a12d16b5de7c1fd78b4bed468a94fbb</id>
<content type='text'>
Signed-off-by: Amitay Isaacs &lt;amitay@gmail.com&gt;
Reviewed-by: Martin Schwenke &lt;martin@meltin.net&gt;

Autobuild-User(master): Martin Schwenke &lt;martins@samba.org&gt;
Autobuild-Date(master): Wed Nov 13 13:31:10 UTC 2019 on sn-devel-184
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Amitay Isaacs &lt;amitay@gmail.com&gt;
Reviewed-by: Martin Schwenke &lt;martin@meltin.net&gt;

Autobuild-User(master): Martin Schwenke &lt;martins@samba.org&gt;
Autobuild-Date(master): Wed Nov 13 13:31:10 UTC 2019 on sn-devel-184
</pre>
</div>
</content>
</entry>
<entry>
<title>ctdb-ib: Avoid fall through case statements</title>
<updated>2018-03-09T06:08:23+00:00</updated>
<author>
<name>Amitay Isaacs</name>
<email>amitay@gmail.com</email>
</author>
<published>2018-03-03T15:09:33+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=f70164d65958956c689f0e2ee3bdd0c7634c146f'/>
<id>f70164d65958956c689f0e2ee3bdd0c7634c146f</id>
<content type='text'>
This is clearly unintended.  Noticed with gcc 7.3.

Signed-off-by: Amitay Isaacs &lt;amitay@gmail.com&gt;
Reviewed-by: Martin Schwenke &lt;martin@meltin.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This is clearly unintended.  Noticed with gcc 7.3.

Signed-off-by: Amitay Isaacs &lt;amitay@gmail.com&gt;
Reviewed-by: Martin Schwenke &lt;martin@meltin.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>ctdb-ib: Fix DEBUG log messages</title>
<updated>2016-08-10T06:18:16+00:00</updated>
<author>
<name>Amitay Isaacs</name>
<email>amitay@gmail.com</email>
</author>
<published>2016-08-02T08:22:13+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=c0246b4cc2c351dced44d28021ee4139bdf7b288'/>
<id>c0246b4cc2c351dced44d28021ee4139bdf7b288</id>
<content type='text'>
https://bugzilla.samba.org/show_bug.cgi?id=12137

Signed-off-by: Amitay Isaacs &lt;amitay@gmail.com&gt;
Reviewed-by: Uri Simchoni &lt;uri@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
https://bugzilla.samba.org/show_bug.cgi?id=12137

Signed-off-by: Amitay Isaacs &lt;amitay@gmail.com&gt;
Reviewed-by: Uri Simchoni &lt;uri@samba.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>ctdb-transport: Replace ctdb_logging.h with common/logging.h</title>
<updated>2015-11-15T23:46:15+00:00</updated>
<author>
<name>Amitay Isaacs</name>
<email>amitay@gmail.com</email>
</author>
<published>2015-11-11T04:22:52+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=921d815da0f0e3a3520cf1bef082188d09fae1b9'/>
<id>921d815da0f0e3a3520cf1bef082188d09fae1b9</id>
<content type='text'>
Signed-off-by: Amitay Isaacs &lt;amitay@gmail.com&gt;
Reviewed-by: Martin Schwenke &lt;martin@meltin.net&gt;
Reviewed-by: Michael Adam &lt;obnox@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Amitay Isaacs &lt;amitay@gmail.com&gt;
Reviewed-by: Martin Schwenke &lt;martin@meltin.net&gt;
Reviewed-by: Michael Adam &lt;obnox@samba.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>ctdb-daemon: Remove dependency on includes.h</title>
<updated>2015-10-30T01:00:27+00:00</updated>
<author>
<name>Amitay Isaacs</name>
<email>amitay@gmail.com</email>
</author>
<published>2015-10-26T05:50:46+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=01c6c90e9818a52854a44e2303362fc39631df2a'/>
<id>01c6c90e9818a52854a44e2303362fc39631df2a</id>
<content type='text'>
Instead of includes.h, include the required header files explicitly.

Signed-off-by: Amitay Isaacs &lt;amitay@gmail.com&gt;
Reviewed-by: Martin Schwenke &lt;martin@meltin.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Instead of includes.h, include the required header files explicitly.

Signed-off-by: Amitay Isaacs &lt;amitay@gmail.com&gt;
Reviewed-by: Martin Schwenke &lt;martin@meltin.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>ctdb-daemon: Stop using tevent compatibility definitions</title>
<updated>2015-10-30T01:00:27+00:00</updated>
<author>
<name>Amitay Isaacs</name>
<email>amitay@gmail.com</email>
</author>
<published>2015-10-26T05:50:09+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=2fdb332fad541efd34be749e55a07569ce2b4ef4'/>
<id>2fdb332fad541efd34be749e55a07569ce2b4ef4</id>
<content type='text'>
Signed-off-by: Amitay Isaacs &lt;amitay@gmail.com&gt;
Reviewed-by: Martin Schwenke &lt;martin@meltin.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Amitay Isaacs &lt;amitay@gmail.com&gt;
Reviewed-by: Martin Schwenke &lt;martin@meltin.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>ctdb-ib: make sure the tevent_fd is removed before the fd is closed</title>
<updated>2015-06-12T15:08:18+00:00</updated>
<author>
<name>Stefan Metzmacher</name>
<email>metze@samba.org</email>
</author>
<published>2015-06-05T08:30:39+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=53ff3e4f31f3debd98f9293171c023a0a406858d'/>
<id>53ff3e4f31f3debd98f9293171c023a0a406858d</id>
<content type='text'>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11316

Signed-off-by: Stefan Metzmacher &lt;metze@samba.org&gt;
Reviewed-by: Volker Lendecke &lt;vl@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11316

Signed-off-by: Stefan Metzmacher &lt;metze@samba.org&gt;
Reviewed-by: Volker Lendecke &lt;vl@samba.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>ctdb-ib: Make infiniband transport compile again</title>
<updated>2014-05-29T01:35:54+00:00</updated>
<author>
<name>Amitay Isaacs</name>
<email>amitay@gmail.com</email>
</author>
<published>2014-05-28T00:40:29+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=f2ef23cd5f227d2da2f032a2a56fbdd4d105b137'/>
<id>f2ef23cd5f227d2da2f032a2a56fbdd4d105b137</id>
<content type='text'>
Update included header files and fix compilation warnings.

  ib/ibwrapper.c: In function ‘ibw_stop’:
  ib/ibwrapper.c:1015:17: warning: comparison between ‘enum ibw_state_ctx’ and ‘enum ibw_state_conn’ [-Wenum-compare]
     if (ctx-&gt;state==IBWC_ERROR || ctx-&gt;state==IBWC_CONNECTED) {
                 ^
  ib/ibwrapper.c:1015:43: warning: comparison between ‘enum ibw_state_ctx’ and ‘enum ibw_state_conn’ [-Wenum-compare]
     if (ctx-&gt;state==IBWC_ERROR || ctx-&gt;state==IBWC_CONNECTED) {

The current logic just seems wrong.  The context of this line and the
error checking in ibw_disconnect() suggest that these comparisons
should use p-&gt;state rather than ctx-&gt;state, so do that.

Signed-off-by: Amitay Isaacs &lt;amitay@gmail.com&gt;
Reviewed-by: Martin Schwenke &lt;martin@meltin.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Update included header files and fix compilation warnings.

  ib/ibwrapper.c: In function ‘ibw_stop’:
  ib/ibwrapper.c:1015:17: warning: comparison between ‘enum ibw_state_ctx’ and ‘enum ibw_state_conn’ [-Wenum-compare]
     if (ctx-&gt;state==IBWC_ERROR || ctx-&gt;state==IBWC_CONNECTED) {
                 ^
  ib/ibwrapper.c:1015:43: warning: comparison between ‘enum ibw_state_ctx’ and ‘enum ibw_state_conn’ [-Wenum-compare]
     if (ctx-&gt;state==IBWC_ERROR || ctx-&gt;state==IBWC_CONNECTED) {

The current logic just seems wrong.  The context of this line and the
error checking in ibw_disconnect() suggest that these comparisons
should use p-&gt;state rather than ctx-&gt;state, so do that.

Signed-off-by: Amitay Isaacs &lt;amitay@gmail.com&gt;
Reviewed-by: Martin Schwenke &lt;martin@meltin.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Whitespace changes and using the CTDB_NO_MEMORY() macro changes to</title>
<updated>2009-05-21T01:49:16+00:00</updated>
<author>
<name>Ronnie Sahlberg</name>
<email>ronniesahlberg@gmail.com</email>
</author>
<published>2009-05-21T01:49:16+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=26e1486db7cafa86d9deceb225820631dfeb2a92'/>
<id>26e1486db7cafa86d9deceb225820631dfeb2a92</id>
<content type='text'>
the previous patch.

(This used to be ctdb commit d623ea7c04daa6349b42d50862843c9f86115488)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
the previous patch.

(This used to be ctdb commit d623ea7c04daa6349b42d50862843c9f86115488)
</pre>
</div>
</content>
</entry>
<entry>
<title>add missing checks on so far ignored return values</title>
<updated>2009-05-21T01:22:21+00:00</updated>
<author>
<name>Sumit Bose</name>
<email>sbose@redhat.com</email>
</author>
<published>2009-05-20T10:08:13+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=2fcedf6dac9dd275adbb0017e53547614df29d93'/>
<id>2fcedf6dac9dd275adbb0017e53547614df29d93</id>
<content type='text'>
Most of these were found during a review by Jim Meyering &lt;meyering@redhat.com&gt;

(This used to be ctdb commit 3aee5ee1deb4a19be3bd3a4ce3abbe09de763344)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Most of these were found during a review by Jim Meyering &lt;meyering@redhat.com&gt;

(This used to be ctdb commit 3aee5ee1deb4a19be3bd3a4ce3abbe09de763344)
</pre>
</div>
</content>
</entry>
</feed>
