samba.git/ctdb/protocol, branch talloc-2.3.4

ctdb-protocol: CID 1499395: Uninitialized variables (UNINIT)

2022-02-23T02:02:06+00:00

Issue is reported here:

853     	case CTDB_CONTROL_DB_VACUUM: {
854     		struct ctdb_db_vacuum db_vacuum;
855
>>>     CID 1499395:  Uninitialized variables  (UNINIT)
>>>     Using uninitialized value "db_vacuum.full_vacuum_run" when calling "ctdb_db_vacuum_len".
856     		CHECK_CONTROL_DATA_SIZE(ctdb_db_vacuum_len(&db_vacuum));
857     		return ctdb_control_db_vacuum(ctdb, c, indata, async_reply);
858     	}

The problem is that ctdb_bool_len() unnecessarily dereferences its
argument, which in this case is &db_vacuum.full_vacuum_run.  Not a
security issue because the value copied by dereferencing is not used.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs 

Autobuild-User(master): Amitay Isaacs 
Autobuild-Date(master): Wed Feb 23 02:02:06 UTC 2022 on sn-devel-184

ctdb-protocol: Mark {GET,SET}_RECMASTER controls obsolete

2022-01-17T10:21:33+00:00

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-protocol: Drop marshalling for {GET,SET}_RECMASTER controls

2022-01-17T10:21:33+00:00

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-protocol: Drop protocol client functions for recmaster controls

2022-01-17T10:21:33+00:00

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-protocol: Add CTDB_SRVID_LEADER

2022-01-17T10:21:32+00:00

CTDB_SRVID_LEADER will be regularly broadcast to all connected nodes
by the leader.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-protocol: Print IPv6 sockets with RFC5952 "[2001:db8::1]:80" notation

2022-01-13T17:02:21+00:00

RFC5952 says the existing style is not recommended and the [] style
should be employed.

There are more optimised ways of adding the square brackets but they
tend to be uglier.

Parsing IPv6 sockets without [] is now tested indirectly by parsing
examples in both styles and comparing the results.

Signed-off-by: Martin Schwenke 
Signed-off-by: Volker Lendecke 

Autobuild-User(master): Volker Lendecke 
Autobuild-Date(master): Thu Jan 13 17:02:21 UTC 2022 on sn-devel-184

ctdb-protocol: Allow rfc5952 "[2001:db8::1]:80" ipv6 notation

2022-01-13T16:13:38+00:00

Bug: https://bugzilla.samba.org/show_bug.cgi?id=14934
Signed-off-by: Volker Lendecke 
Reviewed-by: Martin Schwenke

ctdb-protocol: Save 50 bytes .text segment

2022-01-13T16:13:38+00:00

Having this as a small static .text is simpler than having to create
this on the stack.

Signed-off-by: Volker Lendecke 
Reviewed-by: Martin Schwenke

ctdb-protocol: rindex->strrchr

2022-01-13T16:13:38+00:00

According to "man rindex" on debian bullseye rindex() was deprecated
in Posix.1-2001 and removed from Posix.1-2008.

Signed-off-by: Volker Lendecke 
Reviewed-by: Martin Schwenke

ctdb-recoverd: Mark CTDB_SRVID_SET_NODE_FLAGS obsolete

2021-09-09T01:46:49+00:00

CTDB_SRVID_SET_NODE_FLAGS is no longer sent so drop monitor_handler()
and replace with srvid_not_implemented().  Mark the SRVID obsolete in
its comment.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14784
Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs