samba.git/ctdb/server/eventscript.c, branch talloc-2.4.0

ctdb-daemon: Remove unused #includes of rb_tree.h

2022-05-31T05:06:29+00:00

ctdb_takeover.c and eventscript.c no longer use this.
ipalloc_common.c has never used it.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-daemon: Enable log reopening for event daemon

2022-01-17T03:43:30+00:00

Add and call hook to pass on SIGHUP to eventd.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-daemon: Fix signed/unsigned comparisons by declaring as unsigned

2019-07-05T05:03:23+00:00

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-daemon: Fix valgrind hit in event code

2018-10-22T07:27:15+00:00

==25741== Syscall param write(buf) points to uninitialised byte(s)
==25741==    at 0x4939291: write (write.c:27)
==25741==    by 0x4868285: sys_write (sys_rw.c:68)
==25741==    by 0x13915D: sock_queue_trigger (sock_io.c:316)
==25741==    by 0x4DE6478: tevent_common_invoke_immediate_handler (in /usr/lib/x86_64-linux-gnu/libtevent.so.0.9.37)
==25741==    by 0x4DE64A2: tevent_common_loop_immediate (in /usr/lib/x86_64-linux-gnu/libtevent.so.0.9.37)
==25741==    by 0x4DEBE5A: ??? (in /usr/lib/x86_64-linux-gnu/libtevent.so.0.9.37)
==25741==    by 0x4DEA2D6: ??? (in /usr/lib/x86_64-linux-gnu/libtevent.so.0.9.37)
==25741==    by 0x4DE57E3: _tevent_loop_once (in /usr/lib/x86_64-linux-gnu/libtevent.so.0.9.37)
==25741==    by 0x15D1BA: ctdb_event_script_args (eventscript.c:821)
==25741==    by 0x13B437: ctdb_start_daemon (ctdb_daemon.c:1315)
==25741==    by 0x110642: main (ctdbd.c:393)
==25741==  Address 0x57888a4 is 100 bytes inside a block of size 144 alloc'd
==25741==    at 0x48357BF: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==25741==    by 0x4B9B7C0: talloc_named_const (in /usr/lib/x86_64-linux-gnu/libtalloc.so.2.1.14)
==25741==    by 0x15CCC6: eventd_client_write (eventscript.c:430)
==25741==    by 0x15CCC6: eventd_client_run (eventscript.c:556)
==25741==    by 0x15CCC6: ctdb_event_script_run (eventscript.c:649)
==25741==    by 0x15D198: ctdb_event_script_args (eventscript.c:812)
==25741==    by 0x13B437: ctdb_start_daemon (ctdb_daemon.c:1315)
==25741==    by 0x110642: main (ctdbd.c:393)
==25741==

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13659

Pair-programmed-with: Amitay Isaacs 
Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs 

Autobuild-User(master): Amitay Isaacs 
Autobuild-Date(master): Mon Oct 22 09:27:15 CEST 2018 on sn-devel-144

ctdb-daemon: Exit if eventd goes away

2018-10-22T04:04:20+00:00

ctdbd enters a broken state if eventd goes away.  A clean shutdown is
not possible because that involves running events.  Restarting eventd
is possible but this might mask a serious problem and it is possible
that eventd might keep on disappearing.  Just exit.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13659

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-daemon: Return early when refusing to run an event script

2018-10-22T04:04:20+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13659

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-daemon: Log complete eventd startup command

2018-09-03T08:52:10+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13592

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-daemon: Do not retry connection to eventd

2018-08-30T02:48:56+00:00

Confirmation is now received from eventd that it is accepting
connections, so this is no longer needed.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13592

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-daemon: Wait for eventd to be ready before connecting

2018-08-30T02:48:56+00:00

The current method of retrying the connection to eventd means that
messages get logged for each failure.

Instead, pass a pipe file descriptor to eventd and wait for it to
write 0 to the pipe to indicate that it is ready to accept client
connections.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13592

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-daemon: Open eventd pipe earlier

2018-08-30T02:48:56+00:00

The pipe will soon be needed earlier, so initialise it earlier.
Ensure the file descriptors are closed on error.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13592

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs