samba.git/ctdb/server/ipalloc_common.c, branch talloc-2.4.4 Unnamed repository; edit this file 'description' to name the repository. remove usage of bzero 2025-01-02T17:01:30+00:00 Michael Tokarev mjt@tls.msk.ru 2024-11-18T12:00:05+00:00 bf1e1387ea4a136d06029863eb63b3b1db1c7db0 bzero() function has been deprecated for a long time. In samba it is replaced with memset(). But samba also provides common memory-zeroing macros, like ZERO_STRUCT(). In all places where bzero() is used, it actually meant to zero a structure or an array. So replace these bzero() calls with ZERO_STRUCT() or ZERO_ARRAY() as appropriate, and remove bzero() replacement and testing entirely. While at it, also stop checking for presence of memset() - this function is standard for a very long time, and the only conditional where HAVE_MEMSET were used, was to provide replacement for bzero() - in all other places memset() is used unconditionally. Signed-off-by: Michael Tokarev <mjt@tls.msk.ru> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Pavel Filipenský <pfilipensky@samba.org> 
bzero() function has been deprecated for a long time.
In samba it is replaced with memset().  But samba also
provides common memory-zeroing macros, like ZERO_STRUCT().
In all places where bzero() is used, it actually meant to
zero a structure or an array.

So replace these bzero() calls with ZERO_STRUCT() or
ZERO_ARRAY() as appropriate, and remove bzero() replacement
and testing entirely.

While at it, also stop checking for presence of memset() -
this function is standard for a very long time, and the
only conditional where HAVE_MEMSET were used, was to
provide replacement for bzero() - in all other places
memset() is used unconditionally.

Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Pavel Filipenský <pfilipensky@samba.org>
 ctdb:server: Fix code spelling 2023-03-24T07:01:31+00:00 Andreas Schneider asn@samba.org 2023-03-22T08:36:23+00:00 7749df49924ef30108880580b271657b923639d3 Best reviewed with: `git show --word-diff` Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Martin Schwenke <mschwenke@ddn.com> 
Best reviewed with: `git show --word-diff`

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Martin Schwenke <mschwenke@ddn.com>
 ctdb-daemon: Remove unused #includes of rb_tree.h 2022-05-31T05:06:29+00:00 Martin Schwenke martin@meltin.net 2022-02-22T22:57:33+00:00 da9decfc5e35d7d59987904d4dc03cf2ce1db3e7 ctdb_takeover.c and eventscript.c no longer use this. ipalloc_common.c has never used it. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
ctdb_takeover.c and eventscript.c no longer use this.
ipalloc_common.c has never used it.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb-ipalloc: Avoid -1 as a PNN, use CTDB_UNKNOWN_PNN instead 2019-06-05T10:25:50+00:00 Martin Schwenke martin@meltin.net 2019-05-30T05:40:42+00:00 7df15b246abb9ea2f606f5739a02cfec51f6d9cb This fixes warnings about signed versus unsigned comparisons. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
This fixes warnings about signed versus unsigned comparisons.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb-ipalloc: Fix signed/unsigned comparisons by declaring as unsigned 2019-06-05T10:25:50+00:00 Martin Schwenke martin@meltin.net 2019-05-30T05:37:38+00:00 86666d6570f5377139a18d3e8875e89565bb8ee0 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb-daemon: Drop the noiphost "node flags" bitmap 2018-07-11T09:48:38+00:00 Martin Schwenke martin@meltin.net 2018-06-18T07:00:57+00:00 7c4848a4b3c7b073727f633863e0a92d413c3513 This is no longer needed because inactive/disabled nodes no longer report any available public IP addresses. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
This is no longer needed because inactive/disabled nodes no longer
report any available public IP addresses.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb-protocol: Optionally print port for address printing functions 2017-09-19T11:30:26+00:00 Martin Schwenke martin@meltin.net 2017-09-11T05:00:10+00:00 93668f50266ce43e591f0708bc0dcd557719e2dc Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb-build: Split protocol-util as a separate subsystem 2017-09-19T11:30:26+00:00 Martin Schwenke martin@meltin.net 2017-09-04T06:00:48+00:00 3783b66fb343b9dbbb4a135ff0573c80ef2aba17 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb-ipalloc: Switch noiphost to struct bitmap 2017-02-24T06:47:11+00:00 Martin Schwenke martin@meltin.net 2017-02-03T01:28:44+00:00 5bb6ec6af2359a5b463349df54c168741cb1aca3 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb-ipalloc: Switch available_on to struct bitmap 2017-02-24T06:47:11+00:00 Martin Schwenke martin@meltin.net 2016-12-02T03:21:59+00:00 0b4e609194f1f45d80a7e6274f8de66863b8d6de Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>