samba.git/ctdb/server, branch talloc-2.2.0

ctdb-version: Simplify version string usage

2019-03-15T06:31:50+00:00

There is no need to write SAMBA_VERSION_STRING as CTDB_VERSION_STRING.
Wherever required use SAMBA_VERSION_STRING directly.

Avoids the confusion with two version.h files.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13789

Signed-off-by: Amitay Isaacs 
Reviewed-by: Martin Schwenke 

Autobuild-User(master): Amitay Isaacs 
Autobuild-Date(master): Fri Mar 15 06:31:50 UTC 2019 on sn-devel-144

ctdb-daemon: Add an environment variable to set version

2019-03-15T05:17:14+00:00

This can be used to test the version checking logic.  Cache the
version to avoid re-checking the environment variable each time.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-daemon: Fix maybe-uninitialized error with picky developer

2019-03-01T17:21:15+00:00

263/386] Compiling ctdb/server/ctdb_recovery_helper.c
In file included from ../../server/ctdb_recovery_helper.c:24:0:
../../server/ctdb_recovery_helper.c: In function ‘main’:
../../../lib/talloc/talloc.h:911:34: error: ‘mem_ctx’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
 #define TALLOC_FREE(ctx) do { if (ctx != NULL) { talloc_free(ctx); ctx=NULL; } } while(0)

Signed-off-by: Amitay Isaacs 
Reviewed-by: Jeremy Allison

ctdb-server: Use wrapper for string to integer conversion

2019-03-01T00:32:11+00:00

In order to detect an value overflow error during
the string to integer conversion with strtoul/strtoull,
the errno variable must be set to zero before the execution and
checked after the conversion is performed. This is achieved by
using the wrapper function strtoul_err and strtoull_err.

Signed-off-by: Swen Schillig 
Reviewed-by: Ralph Böhme 
Reviewed-by: Jeremy Allison

ctdb-cluster-mutex: Separate out command and file handling

2019-02-25T02:40:16+00:00

This code is difficult to read and there really is no common code
between the 2 cases.  For example, there is no need to split a
filename into words.  Separating each of the 2 cases into its own
function makes the logic much easier to understand.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13800

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs 

Autobuild-User(master): Amitay Isaacs 
Autobuild-Date(master): Mon Feb 25 03:40:16 CET 2019 on sn-devel-144

ctdb-recoverd: Time out attempt to take recovery lock after 120s

2019-02-25T01:12:17+00:00

Currently this will wait forever.  It really needs a timeout in case
the cluster filesystem (or other lock mechanism) is completely wedged.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13800

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-recoverd: Ban node on unknown error when taking recovery lock

2019-02-25T01:12:17+00:00

We really shouldn't see unknown errors.  They probably represent a
misconfigured recovery lock or similar.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13800

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-recoverd: Make recoverd context available in recovery lock handle

2019-02-25T01:12:16+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13800

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-recoverd: Clean up logging on failure to take recovery lock

2019-02-25T01:12:16+00:00

Add an explicit case for a timeout and clean up the other messages.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13800

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-recoverd: Free cluster mutex handler on failure to take lock

2019-02-25T01:12:16+00:00

If nested events occur while the file descriptor handler is still
active then chaos can ensue.  For example, if a node is banned and the
lock is explicitly cancelled (e.g. due to election loss) then
double-talloc-free()s abound.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13800

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs