samba.git/ctdb/server, branch talloc-2.3.0 Unnamed repository; edit this file 'description' to name the repository. ctdb-daemon: Don't check if lock_ctx->ctdb_db is NULL 2019-07-05T05:03:25+00:00 Martin Schwenke martin@meltin.net 2019-06-24T20:35:04+00:00 755a9e654feaa7265975a1f02ea2f59fd30d09a9 This can never be NULL. It could probably be NULL in the past when "all database" locks existed. There are paths where is is checked for NULL and then later dereferenced, causing static analysers to produce spurious warnings. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
This can never be NULL.  It could probably be NULL in the past when
"all database" locks existed.

There are paths where is is checked for NULL and then later
dereferenced, causing static analysers to produce spurious warnings.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb-daemon: Drop unused function ctdb_vfork_with_logging() 2019-07-05T05:03:24+00:00 Martin Schwenke martin@meltin.net 2019-06-24T04:02:53+00:00 79a7cc3fb976c88a57099fdae239ddd217bcc968 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb-daemon: Don't index by PNN when initialising node flags 2019-07-05T05:03:24+00:00 Martin Schwenke martin@meltin.net 2019-06-21T20:23:12+00:00 75a808fd86a58371b465332f7c9d47d2dfbcbc08 Indexing by PNN is wrong. This also removes a signed/unsigned comparison because the PNN is not compared to -1 anymore. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
Indexing by PNN is wrong.

This also removes a signed/unsigned comparison because the PNN is not
compared to -1 anymore.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb-daemon: Replace function ctdb_ip_to_nodeid() with ctdb_ip_to_pnn() 2019-07-05T05:03:23+00:00 Martin Schwenke martin@meltin.net 2019-06-21T19:53:15+00:00 010c1d77cd7e192b1fff39b7b91fccbdbbf4a786 Node ID is a poorly defined concept, indicating the slot in the node map where the IP address was found. This signed value also ends up compared to num_nodes, which is unsigned, producing unwanted warnings. Just return the PNN because this what both callers really want. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
Node ID is a poorly defined concept, indicating the slot in the node
map where the IP address was found.  This signed value also ends up
compared to num_nodes, which is unsigned, producing unwanted warnings.

Just return the PNN because this what both callers really want.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb-cluster-mutex: Ensure that the configured command is not empty 2019-07-05T05:03:23+00:00 Martin Schwenke martin@meltin.net 2019-06-07T20:56:00+00:00 4c24d434b9610e2865f8288e8046588cd8c551e6 ... and does not just contain whitespace. Otherwise NULL can be passed as the first argument to execv(). Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
... and does not just contain whitespace.

Otherwise NULL can be passed as the first argument to execv().

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb-daemon: Drop unused values assigned to variable 2019-07-05T05:03:23+00:00 Martin Schwenke martin@meltin.net 2019-06-07T20:41:15+00:00 9c75ad68189b258de1224f99b4f1a07409ec4084 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb-daemon: Fix signed/unsigned comparisons by using constant 2019-07-05T05:03:23+00:00 Martin Schwenke martin@meltin.net 2019-06-07T20:40:40+00:00 c39441f62d9a05d2a329dd43a17e51374293de90 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb-daemon: Fix signed/unsigned comparisons by casting 2019-07-05T05:03:23+00:00 Martin Schwenke martin@meltin.net 2019-06-07T20:40:12+00:00 76e930d784e3ea4d8f2076ffc0035a12500db260 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb-daemon: Fix signed/unsigned comparisons by declaring as unsigned 2019-07-05T05:03:23+00:00 Martin Schwenke martin@meltin.net 2019-06-07T20:38:56+00:00 1e47a1b3f6ab1e2ad9d86dfb28c3e086c99a97e5 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb-daemon: Make type of list_of_nodes() consistent with callers 2019-07-05T05:03:22+00:00 Martin Schwenke martin@meltin.net 2019-06-07T20:22:49+00:00 3ccce53e3e6ebb5f7f628bd1b18b7152f548dd27 Instead of taking exclude_pnn as a parameter, calculate it from an include_self_parameter, which is passed through from the 2 calling functions. While doing this, fix a signed/unsigned comparison issue by declaring the new exclude_pnn local variable as an unsigned type. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
Instead of taking exclude_pnn as a parameter, calculate it from an
include_self_parameter, which is passed through from the 2 calling
functions.

While doing this, fix a signed/unsigned comparison issue by declaring
the new exclude_pnn local variable as an unsigned type.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>