samba.git/ctdb/server, branch talloc-2.3.3

ctdb-daemon: Close server socket when switching to client

2021-06-25T09:16:31+00:00

The socket is set close-on-exec but that doesn't help for processes
that do not exec().  This should be done for all child processes.

This has been seen in testing where "ctdb shutdown" waits for the
socket to close before succeeding.  It appears that lingering
vacuuming processes have not closed the socket when becoming clients
so they cause "ctdb shutdown" to hang even though the main daemon
process has exited.  The cause of the lingering vacuuming processes
has been previously examined but still isn't understood.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-locking: Pass additional arguments to debug locks script

2021-05-28T06:46:29+00:00

1. PID of lock helper waiting for lock
2. Scope of lock: "record" or "db"
3. Path to database that lock helper is trying to lock
4. Whether the database uses mutexes: "mutex" or "fcntl"

Signed-off-by: Amitay Isaacs 
Reviewed-by: Martin Schwenke

ctdb: Fix a typo

2021-03-09T22:36:28+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

ctdb-daemon: Do not attempt to chown Unix domain socket in test mode

2020-11-02T08:58:31+00:00

If run with UID wrapper and UID_WRAPPER_ROOT=1 then securing the
socket will fail.

Test mode means that local daemons are in use, so securing the socket
is not important.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs 
Reviewed-by: Volker Lendecke

ctdb-daemon: Clean up call to bind socket

2020-11-02T08:58:31+00:00

Variable res is only used once and ret is re-used many times.  Drop
res, use ret, which doesn't need to be initialised.  Modernise debug
macro.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs 
Reviewed-by: Volker Lendecke

ctdb-daemon: Clean up socket bind/secure/listen

2020-11-02T08:58:31+00:00

Obey the coding style, modernise debug macros, clean up whitespace.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs 
Reviewed-by: Volker Lendecke

ctdb-recoverd: Drop unnecessary and broken code

2020-10-06T03:12:35+00:00

update_flags() has already updated the recovery master's canonical
node map, based on the flags from each remote node, and pushed out
these flags to all nodes.

If i == j then the node map has already been updated from this remote
node's flags, so simply drop this case.

Although update_flags() has updated flags for all nodes, it did not
update each node map in remote_nodemaps[] to reflect this.  This means
that remote_nodemaps[] may contain inconsistent flags for some nodes
so it should not be used to check consistency when i != j.

Further, a meaningful difference in flags can only really occur if
update_flags() failed.  In that case this code is never reached.

These observations combine to imply that this whole loop should be
dropped.

This leaves potential sub-second inconsistencies due to out-of-band
healthy/unhealthy flag changes pushed via CTDB_SRVID_PUSH_NODE_FLAGS.
These updates could be dropped (takeover run asks each node for
available IPs rather than making centralised decisions based on node
flags) but for now they will be fixed in the next iteration of
main_loop().

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14513
Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-recoverd: Drop unnecessary code

2020-10-06T03:12:35+00:00

This has already been done in update_flags().

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14513
Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-daemon: Drop implementation of old-style database pull/push controls

2020-09-11T06:29:32+00:00

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs 

Autobuild-User(master): Amitay Isaacs 
Autobuild-Date(master): Fri Sep 11 06:29:32 UTC 2020 on sn-devel-184

ctdb-recovery: Simplify database push function names

2020-09-11T05:06:42+00:00

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs