samba.git/ctdb/server, branch talloc-2.3.4 Unnamed repository; edit this file 'description' to name the repository. ctdb-recoverd: Do not ban on unknown error when taking cluster lock 2022-05-31T05:06:29+00:00 Martin Schwenke martin@meltin.net 2022-05-19T05:09:41+00:00 90a96f06a938d5fdae33c959c71103add3064b96 If the cluster filesystem is unavailable then I/O errors may occur. This is no worse than contention, so don't ban. This avoids having services unavailable for longer than necessary. Update the associated test to simply confirm that this results in a leaderless cluster, and leadership is restored when the lock can once again be taken. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
If the cluster filesystem is unavailable then I/O errors may occur.
This is no worse than contention, so don't ban.  This avoids having
services unavailable for longer than necessary.

Update the associated test to simply confirm that this results in a
leaderless cluster, and leadership is restored when the lock can once
again be taken.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb-daemon: Remove unused #includes of rb_tree.h 2022-05-31T05:06:29+00:00 Martin Schwenke martin@meltin.net 2022-02-22T22:57:33+00:00 da9decfc5e35d7d59987904d4dc03cf2ce1db3e7 ctdb_takeover.c and eventscript.c no longer use this. ipalloc_common.c has never used it. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
ctdb_takeover.c and eventscript.c no longer use this.
ipalloc_common.c has never used it.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb-daemon: Log per-database summary of resent calls 2022-05-31T05:06:29+00:00 Martin Schwenke martin@meltin.net 2021-10-15T00:10:46+00:00 80de84d36e9c29d9506976f991560fb5dde99471 After a recovery that takes a significant amount of time the logs are flooded with messages about every resent call. Log a summary instead and demote per-call messages to INFO level. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
After a recovery that takes a significant amount of time the logs are
flooded with messages about every resent call.

Log a summary instead and demote per-call messages to INFO level.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb: Covscan: unchecked return value for trbt_traversearray32() 2022-05-14T03:49:32+00:00 Pavel Filipenský pfilipen@redhat.com 2022-05-11T10:06:22+00:00 8cb65650117569dadf5c764f72e5cfb292efb5a4 Signed-off-by: Pavel Filipenský <pfilipen@redhat.com> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> 
Signed-off-by: Pavel Filipenský <pfilipen@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
ctdb-locking: Don't pass NULL to tevent_req_is_unix_error() 2022-05-03T09:19:31+00:00 Martin Schwenke martin@meltin.net 2022-01-21T01:14:05+00:00 d52b497d11a2d5d82fabc8d20d656682af2f3c9d If there is an error then this pointer is unconditionally dereferenced. However, the only possible error appears to be ENOMEM, where a crash caused by dereferencing a NULL pointer isn't a terrible outcome. In the absence of a security issue this is probably not worth backporting. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
If there is an error then this pointer is unconditionally
dereferenced.

However, the only possible error appears to be ENOMEM, where a crash
caused by dereferencing a NULL pointer isn't a terrible outcome.  In
the absence of a security issue this is probably not worth
backporting.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb-mutex: Don't pass NULL to tevent_req_is_unix_error() 2022-05-03T09:19:31+00:00 Martin Schwenke martin@meltin.net 2022-01-21T01:09:45+00:00 490e5f4d4ce2facd4c396a2e213f53de923629c2 If there is an error then this pointer is unconditionally dereferenced. However, the only possible error appears to be ENOMEM, where a crash caused by dereferencing a NULL pointer isn't a terrible outcome. In the absence of a security issue this is probably not worth backporting. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
If there is an error then this pointer is unconditionally
dereferenced.

However, the only possible error appears to be ENOMEM, where a crash
caused by dereferencing a NULL pointer isn't a terrible outcome.  In
the absence of a security issue this is probably not worth
backporting.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb-daemon: Don't release all public IPs during shutdown sequence 2022-04-06T06:34:37+00:00 Martin Schwenke martin@meltin.net 2017-09-11T00:59:42+00:00 6fb08a6580488f961c1d6bcd4b1b9bc3faaf621b This further untangles public IP handling from the main daemon. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
This further untangles public IP handling from the main daemon.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb-daemon: Load tunables from ctdb.tunables 2022-04-06T06:34:37+00:00 Martin Schwenke martin@meltin.net 2022-01-31T03:47:11+00:00 f49446cb1e8dba9cf9c1eff073c394049a0a0cf3 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb-daemon: New function ctdb_tunables_load() 2022-04-06T06:34:37+00:00 Martin Schwenke martin@meltin.net 2022-01-31T03:40:19+00:00 a509ee059ef6783f92b39629c98d7a0a966276f9 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb-recoverd: Consistently log start of election 2022-02-14T01:47:31+00:00 Martin Schwenke martin@meltin.net 2022-01-22T19:21:51+00:00 0e74e03c9cf83d5dc2d97fa9f38ff8fbaa3d2685 Elections should now be quite rare, so always log when one begins. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14958 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
Elections should now be quite rare, so always log when one begins.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14958

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>