samba.git/ctdb/tests/UNIT/shellcheck/scripts, branch master Unnamed repository; edit this file 'description' to name the repository. ctdb-scripts: Avoid ShellCheck warning SC2164 2022-07-22T06:38:32+00:00 Martin Schwenke martin@meltin.net 2022-06-10T00:11:27+00:00 3df39aa7fbd6f8712fda3d90a9c595e7d6aadeef SC2164 (warning): Use 'cd ... || exit' or 'cd ... || return' in case cd fails. A problem can only occur if /etc/ctdb/ or an important subdirectory is removed, which means the script itself would not be found. Use && to silence ShellCheck. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
SC2164 (warning): Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

A problem can only occur if /etc/ctdb/ or an important subdirectory is
removed, which means the script itself would not be found.  Use && to
silence ShellCheck.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb-tests: Drop unreachable line 2020-07-22T07:53:35+00:00 Martin Schwenke martin@meltin.net 2020-04-30T04:14:43+00:00 0f201dd67a019d4d64011b894ebf542b109afef4 ctdb_test_skip() will exit. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
ctdb_test_skip() will exit.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
 ctdb-tests: Redirect stderr too when checking for shellcheck 2020-07-22T07:53:35+00:00 Martin Schwenke martin@meltin.net 2020-03-11T05:33:27+00:00 29a3fce28f380e3b5c2e44a697fbf35be2a139da Avoid: .../UNIT/shellcheck/scripts/local.sh: line 14: type: shellcheck: not found The "type" command in dash prints the "not found" message to stdout but the bash version prints to stderr, so redirect stderr too. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
Avoid:

  .../UNIT/shellcheck/scripts/local.sh: line 14: type: shellcheck: not found

The "type" command in dash prints the "not found" message to stdout
but the bash version prints to stderr, so redirect stderr too.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
 Revert "ctdb-tests: Redirect stderr too when checking for shellcheck" 2020-07-22T05:07:46+00:00 Martin Schwenke martin@meltin.net 2020-07-22T04:43:31+00:00 e4b1cdc7090212c8b2f37b9ba8303439348e00b8 Fix missing Reviewed-by: tag. This reverts commit 847aa0e367c721944650aa34d67f8073461ae272. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
Fix missing Reviewed-by: tag.

This reverts commit 847aa0e367c721944650aa34d67f8073461ae272.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Revert "ctdb-tests: Drop unreachable line" 2020-07-22T05:07:46+00:00 Martin Schwenke martin@meltin.net 2020-07-22T04:43:28+00:00 a694c07126e0dacb3bd30502e83264ffef98e0c0 Fix missing Reviewed-by: tag. This reverts commit a55dd6f17b6d65db77bcd4f5a011e9aef64729e5. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
Fix missing Reviewed-by: tag.

This reverts commit a55dd6f17b6d65db77bcd4f5a011e9aef64729e5.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb-tests: Drop unreachable line 2020-07-22T02:42:37+00:00 Martin Schwenke martin@meltin.net 2020-04-30T04:14:43+00:00 a55dd6f17b6d65db77bcd4f5a011e9aef64729e5 ctdb_test_skip() will exit. Signed-off-by: Martin Schwenke <martin@meltin.net> 
ctdb_test_skip() will exit.

Signed-off-by: Martin Schwenke <martin@meltin.net>
ctdb-tests: Redirect stderr too when checking for shellcheck 2020-07-22T02:42:37+00:00 Martin Schwenke martin@meltin.net 2020-03-11T05:33:27+00:00 847aa0e367c721944650aa34d67f8073461ae272 Avoid: .../UNIT/shellcheck/scripts/local.sh: line 14: type: shellcheck: not found The "type" command in dash prints the "not found" message to stdout but the bash version prints to stderr, so redirect stderr too. Signed-off-by: Martin Schwenke <martin@meltin.net> 
Avoid:

  .../UNIT/shellcheck/scripts/local.sh: line 14: type: shellcheck: not found

The "type" command in dash prints the "not found" message to stdout
but the bash version prints to stderr, so redirect stderr too.

Signed-off-by: Martin Schwenke <martin@meltin.net>
ctdb-tests: Use ctdb_test_skip() when shellcheck is not installed 2020-03-10T07:37:34+00:00 Martin Schwenke martin@meltin.net 2020-03-03T06:48:40+00:00 30180ef6c280a7aa3d683ae33877daa60ce6b3dd When the tests are run interactively this will make it more noticeable that shellcheck is not installed because the test summary will indicate missing tests. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
When the tests are run interactively this will make it more noticeable
that shellcheck is not installed because the test summary will
indicate missing tests.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb-tests: Move shellcheck tests to UNIT/ subdirectory 2019-09-26T04:45:36+00:00 Martin Schwenke martin@meltin.net 2019-09-09T00:48:05+00:00 010c1a85fa9719b726d26c48aa3373f2e328e8f0 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>