samba.git/ctdb/tests/UNIT, branch talloc-2.4.4 Unnamed repository; edit this file 'description' to name the repository. ctdb-tests: Add tests for tunables directory loading 2025-07-22T23:02:34+00:00 Martin Schwenke mschwenke@ddn.com 2025-06-27T07:35:03+00:00 6863799ce93b655f2f412f304b1556b9f09dd1a9 The missing 2nd file testcase becomes the missing directory testcase, because you can't easily have both. See the comment in tunable_test.c. Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
The missing 2nd file testcase becomes the missing directory testcase,
because you can't easily have both.  See the comment in
tunable_test.c.

Signed-off-by: Martin Schwenke <mschwenke@ddn.com>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
 ctdb-tests: Allow tunables unit test to process a second file 2025-07-22T23:02:34+00:00 Martin Schwenke mschwenke@ddn.com 2025-06-25T12:14:05+00:00 de069d6b950531b3c2ad4584ae661980bd25a982 The second file is optional. Make $tfile the default to avoid having to update all of the single file testcases. Add test cases for second file. Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
The second file is optional.

Make $tfile the default to avoid having to update all of the single
file testcases.

Add test cases for second file.

Signed-off-by: Martin Schwenke <mschwenke@ddn.com>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
 ctdb-common: Log tunables filename instead of function name 2025-07-22T23:02:34+00:00 Martin Schwenke mschwenke@ddn.com 2025-06-27T05:05:04+00:00 4352a8da5ac05b8745b6197fa80774d8b0fe5f4b When loading multiple files, this is more informative. Tweak a couple of error messages to ensure they all mention "tunables". Update the unit testcases to match. Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
When loading multiple files, this is more informative.

Tweak a couple of error messages to ensure they all mention
"tunables".

Update the unit testcases to match.

Signed-off-by: Martin Schwenke <mschwenke@ddn.com>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
 ctdb-common: Log a message if the tunables file does not exist 2025-07-22T23:02:34+00:00 Martin Schwenke mschwenke@ddn.com 2025-06-29T00:16:20+00:00 cdb02782f950bf3a7585a8390a0c40ed81cd3971 Switch the unit test script to INFO debug level to ensure this output appears when expected. Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
Switch the unit test script to INFO debug level to ensure this output
appears when expected.

Signed-off-by: Martin Schwenke <mschwenke@ddn.com>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
 ctdb-tests: Add logging support to the tunables unit test 2025-07-22T23:02:34+00:00 Martin Schwenke mschwenke@ddn.com 2025-06-28T02:01:41+00:00 7d010715c591fc05871078958c08eb7207729c65 Make tunable_test respect CTDB_DEBUGLEVEL. Using test_options.[ch] would be overkill here. This means including logging.c - we can't link to the subsystem containing logging.c because the file being tested (tunable.c) is part of that subsystem. Support logging in the test script. tunable_ok() builds the logging output for the good path. Set the debug level to NOTICE and update expected results for individual failure path tests. Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
Make tunable_test respect CTDB_DEBUGLEVEL.  Using test_options.[ch]
would be overkill here.  This means including logging.c - we can't
link to the subsystem containing logging.c because the file being
tested (tunable.c) is part of that subsystem.

Support logging in the test script.  tunable_ok() builds the logging
output for the good path.  Set the debug level to NOTICE and update
expected results for individual failure path tests.

Signed-off-by: Martin Schwenke <mschwenke@ddn.com>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
 ctdb-common: Require separate initialisation of tunable defaults 2025-07-22T23:02:34+00:00 Martin Schwenke mschwenke@ddn.com 2025-06-25T10:46:26+00:00 2ec739a039e3a9af82e614afeae54359fb05b288 Dropping this from ctdb_tunable_load_file() allows that function to be called multiple times for different files. The caller sets the defaults. In the test script, factor out the handling of a single tunables file in a similar way. Ignoring missing/unreadable files is OK because this function will only be called for test successes (hence "ok" in the name). There will never be existing, unreadable files. The code being tested ignores missing files, so do that here too. Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
Dropping this from ctdb_tunable_load_file() allows that function to be
called multiple times for different files.  The caller sets the
defaults.

In the test script, factor out the handling of a single tunables file
in a similar way.  Ignoring missing/unreadable files is OK because
this function will only be called for test successes (hence "ok" in
the name).  There will never be existing, unreadable files.  The code
being tested ignores missing files, so do that here too.

Signed-off-by: Martin Schwenke <mschwenke@ddn.com>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
 ctdb-tests: Reformat with "shfmt -w -p -i 0 -fn" 2025-07-22T23:02:34+00:00 Martin Schwenke mschwenke@ddn.com 2025-06-28T02:12:33+00:00 968657643052a90bab1deb5ffd4938a256e5ee14 Best reviewed with "git show -w". Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
Best reviewed with "git show -w".

Signed-off-by: Martin Schwenke <mschwenke@ddn.com>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
 ctdb-daemon: Add configuration option shutdown extra timeout 2025-05-29T09:56:31+00:00 Martin Schwenke mschwenke@ddn.com 2025-05-18T23:06:38+00:00 3a770c8d46934870f42059640b0aaa0c76a3f4fb See documentation change for details. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15858 Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
See documentation change for details.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15858

Signed-off-by: Martin Schwenke <mschwenke@ddn.com>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
 ctdb-daemon: Add configuration option shutdown failover timeout 2025-05-29T09:56:31+00:00 Martin Schwenke mschwenke@ddn.com 2025-05-12T02:00:28+00:00 dd9b73119afd3a0c60c87c938b5aefc766ca78d2 Allows the timeout for failover during shutdown to be modified. Defaults to 10s. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15858 Signed-off-by: Martin Schwenke <mschwenke@ddn.com> SQ Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
Allows the timeout for failover during shutdown to be modified.
Defaults to 10s.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15858

Signed-off-by: Martin Schwenke <mschwenke@ddn.com>

SQ

Reviewed-by: Amitay Isaacs <amitay@gmail.com>
 ctdb-scripts: Change default persistent DB for statd_callout_helper 2024-12-13T15:01:10+00:00 Martin Schwenke mschwenke@ddn.com 2024-06-25T01:06:19+00:00 86cdaf5a2eeb9252fe16dfa4d215065cf1c748c2 This database isn't use throughout CTDB, so name the it more specifically. Note that this might cause locks to be lost during upgrade to the first version containing this change. For testing, a different name is chosen to exercise related functionality. Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: Amitay Isaacs <amitay@gmail.com> Autobuild-User(master): Amitay Isaacs <amitay@samba.org> Autobuild-Date(master): Fri Dec 13 15:01:10 UTC 2024 on atb-devel-224 
This database isn't use throughout CTDB, so name the it more
specifically.

Note that this might cause locks to be lost during upgrade to the
first version containing this change.

For testing, a different name is chosen to exercise related
functionality.

Signed-off-by: Martin Schwenke <mschwenke@ddn.com>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Fri Dec 13 15:01:10 UTC 2024 on atb-devel-224