samba.git/ctdb/tests/scripts/integration.bash, branch talloc-2.3.2

ctdb-tests: Don't bother shutting down daemons in ctdb_init()

2020-07-22T07:53:36+00:00

They'll never be up here...

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-tests: Separate custom cluster startup from test initialisation

2020-07-22T07:53:36+00:00

Separate cluster startup from test initialisation for tests that start
the cluster with customised configuration.  In these cases the result
of the cluster startup is actually the point of the test.
Additionally, pubips.013.failover_noop.sh claims to have completed
test initialisation twice, which just seems wrong.

The result is:

* ctdb_test_init() takes one option (-n) to indicate when it should
  not configure/start the cluster

* New function ctdb_nodes_start_custom() accepts options for special
  cluster configuration, only operates on local daemons and triggers a
  test failure rather than a test error on failure.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-tests: Do not trigger ctdb_test_error() from ctdb_init()

2020-07-22T07:53:36+00:00

The only caller calls ctdb_test_error() on failure and nesting this
calls can be confusing.  A future change will make this even more
confusing.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-tests: Make integration.bash pass shellcheck

2020-07-22T07:53:36+00:00

Apart from the non-constant sourcing of include files.

Mostly avoidance of quoting warnings.

One subtle change is to simply pass "120" to wait_until_ready() to
stop warnings that it expects arguments but none are passed (both
SC2119 and SC2120).  There seems no way to indicate to structure
function argument handling so that shellcheck realises arguments are
optional.  In later shellcheck versions, disabling SC2120 for a
function also silences complaints about its callers... but not all of
our testing uses "later" shellcheck versions.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-tests: Stop cat command failure from causing test failure

2020-07-22T07:53:35+00:00

In certain circumstance, which aren't obvious, cat(1) can fail when
attempting to write a lot of data.  This is due to something (probably
write(2)) returning EAGAIN.

Given that the -v option should only really be used for test
debugging, ignore the failure instead of spending time debugging it.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14446
Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

Revert "ctdb-tests: Make integration.bash pass shellcheck"

2020-07-22T05:07:46+00:00

Fix missing Reviewed-by: tag.

This reverts commit 0f04b8a70be3b8e157a4a88e9e54e87fa380022e.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

Revert "ctdb-tests: Do not trigger ctdb_test_error() from ctdb_init()"

2020-07-22T05:07:46+00:00

Fix missing Reviewed-by: tag.

This reverts commit 44e05ac8515be3220a334ae8001db83b06bec59f.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

Revert "ctdb-tests: Separate custom cluster startup from test initialisation"

2020-07-22T05:07:45+00:00

Fix missing Reviewed-by: tag.

This reverts commit e9df17b500146e62539feac66d0cd4b3ef7aa47a.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

Revert "ctdb-tests: Don't bother shutting down daemons in ctdb_init()"

2020-07-22T05:07:45+00:00

Fix missing Reviewed-by: tag.

This reverts commit 58f9f699f181ac217cda8de512b8385da173f884.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

Revert "ctdb-tests: Stop cat command failure from causing test failure"

2020-07-22T05:07:45+00:00

Fix missing Reviewed-by: tag.

This reverts commit 5707781ccf682d95a5a05a7c3e00a43003dbe62e.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs