<feed xmlns='http://www.w3.org/2005/Atom'>
<title>samba.git/ctdb/tests/scripts, branch master</title>
<subtitle>Unnamed repository; edit this file 'description' to name the repository.</subtitle>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/'/>
<entry>
<title>ctdb-tests: Reorder and group script variables, add comments</title>
<updated>2026-02-25T12:33:39+00:00</updated>
<author>
<name>Martin Schwenke</name>
<email>mschwenke@ddn.com</email>
</author>
<published>2025-10-31T03:46:23+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=369ba7c270b3fce87fd06e55237424395a6378d4'/>
<id>369ba7c270b3fce87fd06e55237424395a6378d4</id>
<content type='text'>
Signed-off-by: Martin Schwenke &lt;mschwenke@ddn.com&gt;
Reviewed-by: Anoop C S &lt;anoopcs@samba.org&gt;</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Martin Schwenke &lt;mschwenke@ddn.com&gt;
Reviewed-by: Anoop C S &lt;anoopcs@samba.org&gt;</pre>
</div>
</content>
</entry>
<entry>
<title>ctdb-tests: Remove unused helper variable CTDB_SCRIPTS_HELPER_BINDIR</title>
<updated>2026-02-25T12:33:39+00:00</updated>
<author>
<name>Martin Schwenke</name>
<email>mschwenke@ddn.com</email>
</author>
<published>2025-10-29T09:46:03+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=82eb177e6213c222c1a0458063cabaeeff4d2603'/>
<id>82eb177e6213c222c1a0458063cabaeeff4d2603</id>
<content type='text'>
Signed-off-by: Martin Schwenke &lt;mschwenke@ddn.com&gt;
Reviewed-by: Anoop C S &lt;anoopcs@samba.org&gt;</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Martin Schwenke &lt;mschwenke@ddn.com&gt;
Reviewed-by: Anoop C S &lt;anoopcs@samba.org&gt;</pre>
</div>
</content>
</entry>
<entry>
<title>ctdb-tools: Remove some helper variables</title>
<updated>2026-02-25T12:33:39+00:00</updated>
<author>
<name>Martin Schwenke</name>
<email>mschwenke@ddn.com</email>
</author>
<published>2025-10-27T06:36:27+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=2628f86c6599472d241f0ccdbe0d151fed0e08aa'/>
<id>2628f86c6599472d241f0ccdbe0d151fed0e08aa</id>
<content type='text'>
Remove CTDB_EVENT_HELPER, CTDB_LVS_HELPER, CTDB_NATGW_HELPER.  Use
path_helperdir_append() instead.

Signed-off-by: Martin Schwenke &lt;mschwenke@ddn.com&gt;
Reviewed-by: Anoop C S &lt;anoopcs@samba.org&gt;</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Remove CTDB_EVENT_HELPER, CTDB_LVS_HELPER, CTDB_NATGW_HELPER.  Use
path_helperdir_append() instead.

Signed-off-by: Martin Schwenke &lt;mschwenke@ddn.com&gt;
Reviewed-by: Anoop C S &lt;anoopcs@samba.org&gt;</pre>
</div>
</content>
</entry>
<entry>
<title>ctdb-tests: Add CTDB_TEST_HELPER_BINDIR</title>
<updated>2026-02-25T12:33:39+00:00</updated>
<author>
<name>Martin Schwenke</name>
<email>mschwenke@ddn.com</email>
</author>
<published>2025-10-29T04:22:22+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=6c4564912847ffb7f4bbaa52cd16883cb80849c4'/>
<id>6c4564912847ffb7f4bbaa52cd16883cb80849c4</id>
<content type='text'>
Now that generated scripts are linked into bin/, nothing needs to be
run from the tools/ directory anymore during self-test.  So, introduce
CTDB_TEST_HELPER_BINDIR to replace both CTDB_SCRIPTS_TOOLS_HELPER_DIR
and CTDB_SCRIPTS_HELPER_BINDIR.  Add this directory to PATH.

CTDB_TEST_HELPER_BINDIR will also be used in combination with
CTDB_TEST_MODE to allow helpers to be found via a single mechanism
that uses this single variable.  This will replace the multiple
mechanisms and variables currently used.

For simplicity, leave the old variables alone for now.  Replacing them
in a comprehensible way will take a few steps.

Signed-off-by: Martin Schwenke &lt;mschwenke@ddn.com&gt;
Reviewed-by: Anoop C S &lt;anoopcs@samba.org&gt;</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Now that generated scripts are linked into bin/, nothing needs to be
run from the tools/ directory anymore during self-test.  So, introduce
CTDB_TEST_HELPER_BINDIR to replace both CTDB_SCRIPTS_TOOLS_HELPER_DIR
and CTDB_SCRIPTS_HELPER_BINDIR.  Add this directory to PATH.

CTDB_TEST_HELPER_BINDIR will also be used in combination with
CTDB_TEST_MODE to allow helpers to be found via a single mechanism
that uses this single variable.  This will replace the multiple
mechanisms and variables currently used.

For simplicity, leave the old variables alone for now.  Replacing them
in a comprehensible way will take a few steps.

Signed-off-by: Martin Schwenke &lt;mschwenke@ddn.com&gt;
Reviewed-by: Anoop C S &lt;anoopcs@samba.org&gt;</pre>
</div>
</content>
</entry>
<entry>
<title>ctdb-tests: Add a useful comment</title>
<updated>2026-02-25T12:33:38+00:00</updated>
<author>
<name>Martin Schwenke</name>
<email>mschwenke@ddn.com</email>
</author>
<published>2025-10-29T02:58:00+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=ad933b2bd8d83e9ee68868a1f96d58301f35a191'/>
<id>ad933b2bd8d83e9ee68868a1f96d58301f35a191</id>
<content type='text'>
Signed-off-by: Martin Schwenke &lt;mschwenke@ddn.com&gt;
Reviewed-by: Anoop C S &lt;anoopcs@samba.org&gt;</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Martin Schwenke &lt;mschwenke@ddn.com&gt;
Reviewed-by: Anoop C S &lt;anoopcs@samba.org&gt;</pre>
</div>
</content>
</entry>
<entry>
<title>ctdb-tests: Remove unused variables</title>
<updated>2026-02-25T12:33:38+00:00</updated>
<author>
<name>Martin Schwenke</name>
<email>mschwenke@ddn.com</email>
</author>
<published>2025-10-29T01:01:27+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=e4aae52c60e16b5870b7a7f0238175a7353d04ae'/>
<id>e4aae52c60e16b5870b7a7f0238175a7353d04ae</id>
<content type='text'>
Signed-off-by: Martin Schwenke &lt;mschwenke@ddn.com&gt;
Reviewed-by: Anoop C S &lt;anoopcs@samba.org&gt;</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Martin Schwenke &lt;mschwenke@ddn.com&gt;
Reviewed-by: Anoop C S &lt;anoopcs@samba.org&gt;</pre>
</div>
</content>
</entry>
<entry>
<title>ctdb-tests: Don't hard code creation of $CTDB_BASE/events/legacy/</title>
<updated>2025-10-14T17:57:49+00:00</updated>
<author>
<name>Martin Schwenke</name>
<email>mschwenke@ddn.com</email>
</author>
<published>2025-10-11T06:52:32+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=d950c7399796458bcbfda4d7d8d3de3a24b532dd'/>
<id>d950c7399796458bcbfda4d7d8d3de3a24b532dd</id>
<content type='text'>
setup_ctdb_base() should always create from etc-ctdb/.  That directory
may be changed to not include the legacy/ component subdirectory, so
don't hard-code this particular subdirectory.

Signed-off-by: Martin Schwenke &lt;mschwenke@ddn.com&gt;
Reviewed-by: Ralph Boehme &lt;slow@samba.org&gt;

Autobuild-User(master): Ralph Böhme &lt;slow@samba.org&gt;
Autobuild-Date(master): Tue Oct 14 17:57:49 UTC 2025 on atb-devel-224
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
setup_ctdb_base() should always create from etc-ctdb/.  That directory
may be changed to not include the legacy/ component subdirectory, so
don't hard-code this particular subdirectory.

Signed-off-by: Martin Schwenke &lt;mschwenke@ddn.com&gt;
Reviewed-by: Ralph Boehme &lt;slow@samba.org&gt;

Autobuild-User(master): Ralph Böhme &lt;slow@samba.org&gt;
Autobuild-Date(master): Tue Oct 14 17:57:49 UTC 2025 on atb-devel-224
</pre>
</div>
</content>
</entry>
<entry>
<title>ctdb-tests: Improve setup_ctdb_base() to fix local_daemons.sh bug</title>
<updated>2025-10-14T16:53:36+00:00</updated>
<author>
<name>Martin Schwenke</name>
<email>mschwenke@ddn.com</email>
</author>
<published>2025-10-07T11:27:06+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=98cecce76d15308e321a3ce57ce389ad457ee858'/>
<id>98cecce76d15308e321a3ce57ce389ad457ee858</id>
<content type='text'>
$ ctdb/tests/local_daemons.sh foo onnode 0 ctdb event script list legacy
Unable to find event script installation directory: foo/node.0/share/events/legacy

This happens if the $CTDB_BASE/share/events/legacy/ directory does not
exist.  This directory is (theoretically) for installed but not
necessarily enabled event scripts.  ctdb/tests/etc-ctdb/ contains
events/legacy/ but setup_ctdb_base() currently does not ensure
creation of the corresponding directory under $CTDB_BASE/share/.

Ensure that an event script component installation subdirectory exists
for each corresponding configuration subdirectory.

An alternative would be to continue to allow the existing failure, but
create directory ctdb/tests/etc-ctdb/share/events/legacy/ specifically
to make local_daemons.sh work.  However, it took 5 years to find the
current bug, so this may be too subtle for other users of
local_daemons.sh.  Anyone wanting to test the failure case can remove
unwanted subdirectories after "local_daemons.sh setup".

Signed-off-by: Martin Schwenke &lt;mschwenke@ddn.com&gt;
Reviewed-by: Ralph Boehme &lt;slow@samba.org&gt;</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
$ ctdb/tests/local_daemons.sh foo onnode 0 ctdb event script list legacy
Unable to find event script installation directory: foo/node.0/share/events/legacy

This happens if the $CTDB_BASE/share/events/legacy/ directory does not
exist.  This directory is (theoretically) for installed but not
necessarily enabled event scripts.  ctdb/tests/etc-ctdb/ contains
events/legacy/ but setup_ctdb_base() currently does not ensure
creation of the corresponding directory under $CTDB_BASE/share/.

Ensure that an event script component installation subdirectory exists
for each corresponding configuration subdirectory.

An alternative would be to continue to allow the existing failure, but
create directory ctdb/tests/etc-ctdb/share/events/legacy/ specifically
to make local_daemons.sh work.  However, it took 5 years to find the
current bug, so this may be too subtle for other users of
local_daemons.sh.  Anyone wanting to test the failure case can remove
unwanted subdirectories after "local_daemons.sh setup".

Signed-off-by: Martin Schwenke &lt;mschwenke@ddn.com&gt;
Reviewed-by: Ralph Boehme &lt;slow@samba.org&gt;</pre>
</div>
</content>
</entry>
<entry>
<title>ctdb-tests: Reformat with "shfmt -w -i 0 -fn "</title>
<updated>2025-10-14T16:53:36+00:00</updated>
<author>
<name>Martin Schwenke</name>
<email>mschwenke@ddn.com</email>
</author>
<published>2025-10-07T11:48:40+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=4ba5a8ff106653292432d7cc32e1f2c8fca2a650'/>
<id>4ba5a8ff106653292432d7cc32e1f2c8fca2a650</id>
<content type='text'>
Best reviewed with "git show -w".

Signed-off-by: Martin Schwenke &lt;mschwenke@ddn.com&gt;
Reviewed-by: Ralph Boehme &lt;slow@samba.org&gt;</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Best reviewed with "git show -w".

Signed-off-by: Martin Schwenke &lt;mschwenke@ddn.com&gt;
Reviewed-by: Ralph Boehme &lt;slow@samba.org&gt;</pre>
</div>
</content>
</entry>
<entry>
<title>ctdb-scripts: Remove unnecessary 06.nfs.script</title>
<updated>2024-03-06T06:05:38+00:00</updated>
<author>
<name>Vinit Agnihotri</name>
<email>vagnihotri@ddn.com</email>
</author>
<published>2023-10-27T06:35:25+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=2de2d5dd2018708eeca7e8a7c66015f81bcaf693'/>
<id>2de2d5dd2018708eeca7e8a7c66015f81bcaf693</id>
<content type='text'>
Signed-off-by: Vinit Agnihotri &lt;vagnihotri@ddn.com&gt;
Signed-off-by: Martin Schwenke &lt;mschwenke@ddn.com&gt;
Reviewed-by: Volker Lendecke &lt;vl@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Vinit Agnihotri &lt;vagnihotri@ddn.com&gt;
Signed-off-by: Martin Schwenke &lt;mschwenke@ddn.com&gt;
Reviewed-by: Volker Lendecke &lt;vl@samba.org&gt;
</pre>
</div>
</content>
</entry>
</feed>
