<feed xmlns='http://www.w3.org/2005/Atom'>
<title>samba.git/ctdb/tests, branch master</title>
<subtitle>Unnamed repository; edit this file 'description' to name the repository.</subtitle>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/'/>
<entry>
<title>ctdb-scripts: Support interface altnames</title>
<updated>2026-04-17T00:11:50+00:00</updated>
<author>
<name>Martin Schwenke</name>
<email>mschwenke@ddn.com</email>
</author>
<published>2026-04-09T07:52:20+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=b605cc7c88089fc5e2f5cce08543e7dbae148a24'/>
<id>b605cc7c88089fc5e2f5cce08543e7dbae148a24</id>
<content type='text'>
This avoids generating a warning like:

  WARNING: Public IP &lt;ip&gt; hosted on interface &lt;iface&gt; but VNN says &lt;altname&gt;

every time a public IP is removed from an interface that is configured
via an altname.

The new check will nearly always be successful because the IP will be
on the expected interface during releaseip/updateip.

The original check is now used as a backup when the IP is not on the
expected interface.  To allow the mask bits check to cover both cases,
the original check and the associated interface check needs to be
inside the else clause.

Update the unit test to reflect the change.

Best reviewed with "git show -w" or similar.

Signed-off-by: Martin Schwenke &lt;mschwenke@ddn.com&gt;
Reviewed-by: John Mulligan &lt;jmulligan@redhat.com&gt;

Autobuild-User(master): Martin Schwenke &lt;martins@samba.org&gt;
Autobuild-Date(master): Fri Apr 17 00:11:50 UTC 2026 on atb-devel-224
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This avoids generating a warning like:

  WARNING: Public IP &lt;ip&gt; hosted on interface &lt;iface&gt; but VNN says &lt;altname&gt;

every time a public IP is removed from an interface that is configured
via an altname.

The new check will nearly always be successful because the IP will be
on the expected interface during releaseip/updateip.

The original check is now used as a backup when the IP is not on the
expected interface.  To allow the mask bits check to cover both cases,
the original check and the associated interface check needs to be
inside the else clause.

Update the unit test to reflect the change.

Best reviewed with "git show -w" or similar.

Signed-off-by: Martin Schwenke &lt;mschwenke@ddn.com&gt;
Reviewed-by: John Mulligan &lt;jmulligan@redhat.com&gt;

Autobuild-User(master): Martin Schwenke &lt;martins@samba.org&gt;
Autobuild-Date(master): Fri Apr 17 00:11:50 UTC 2026 on atb-devel-224
</pre>
</div>
</content>
</entry>
<entry>
<title>ctdb-tests: Add addip/releaseip altname unit test</title>
<updated>2026-04-16T23:09:33+00:00</updated>
<author>
<name>Martin Schwenke</name>
<email>mschwenke@ddn.com</email>
</author>
<published>2026-04-13T04:48:07+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=8c8dded9481cae424df0205dd06bfc49014dcf63'/>
<id>8c8dded9481cae424df0205dd06bfc49014dcf63</id>
<content type='text'>
This shows that a warning is generated whenever an IP address is
removed using an altname.

Signed-off-by: Martin Schwenke &lt;mschwenke@ddn.com&gt;
Reviewed-by: John Mulligan &lt;jmulligan@redhat.com&gt;</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This shows that a warning is generated whenever an IP address is
removed using an altname.

Signed-off-by: Martin Schwenke &lt;mschwenke@ddn.com&gt;
Reviewed-by: John Mulligan &lt;jmulligan@redhat.com&gt;</pre>
</div>
</content>
</entry>
<entry>
<title>ctdb-tests: Implement altname property for ip link/addr</title>
<updated>2026-04-16T23:09:33+00:00</updated>
<author>
<name>Martin Schwenke</name>
<email>mschwenke@ddn.com</email>
</author>
<published>2026-04-13T04:18:28+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=65bb57ebf486692705efcf395f06be4c41261047'/>
<id>65bb57ebf486692705efcf395f06be4c41261047</id>
<content type='text'>
Only implemented for these commands.  I don't even want to think about
doing this for ip route right now.

Signed-off-by: Martin Schwenke &lt;mschwenke@ddn.com&gt;
Reviewed-by: John Mulligan &lt;jmulligan@redhat.com&gt;</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Only implemented for these commands.  I don't even want to think about
doing this for ip route right now.

Signed-off-by: Martin Schwenke &lt;mschwenke@ddn.com&gt;
Reviewed-by: John Mulligan &lt;jmulligan@redhat.com&gt;</pre>
</div>
</content>
</entry>
<entry>
<title>ctdb-tests: Implement -brief option for ip addr show stub</title>
<updated>2026-04-16T23:09:33+00:00</updated>
<author>
<name>Martin Schwenke</name>
<email>mschwenke@ddn.com</email>
</author>
<published>2026-04-08T03:02:52+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=416c38003ff2824a0ec83a1171b9807c692a377b'/>
<id>416c38003ff2824a0ec83a1171b9807c692a377b</id>
<content type='text'>
Signed-off-by: Martin Schwenke &lt;mschwenke@ddn.com&gt;
Reviewed-by: John Mulligan &lt;jmulligan@redhat.com&gt;</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Martin Schwenke &lt;mschwenke@ddn.com&gt;
Reviewed-by: John Mulligan &lt;jmulligan@redhat.com&gt;</pre>
</div>
</content>
</entry>
<entry>
<title>ctdb-tests: Fix a typo in "ip link show" stub output</title>
<updated>2026-04-16T23:09:33+00:00</updated>
<author>
<name>Martin Schwenke</name>
<email>mschwenke@ddn.com</email>
</author>
<published>2026-04-08T02:10:43+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=ee9b18876b4e7c104e9668a755a088b4933a2514'/>
<id>ee9b18876b4e7c104e9668a755a088b4933a2514</id>
<content type='text'>
Status is different to state and should not be repeated.  For example:

eth0             UP             aa:bb:cc:dd:ee:ff &lt;BROADCAST,MULTICAST,UP,LOWER_UP&gt;

Clearly nothing looks at this field but it should be correct.

Signed-off-by: Martin Schwenke &lt;mschwenke@ddn.com&gt;
Reviewed-by: John Mulligan &lt;jmulligan@redhat.com&gt;</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Status is different to state and should not be repeated.  For example:

eth0             UP             aa:bb:cc:dd:ee:ff &lt;BROADCAST,MULTICAST,UP,LOWER_UP&gt;

Clearly nothing looks at this field but it should be correct.

Signed-off-by: Martin Schwenke &lt;mschwenke@ddn.com&gt;
Reviewed-by: John Mulligan &lt;jmulligan@redhat.com&gt;</pre>
</div>
</content>
</entry>
<entry>
<title>ctdb-scripts: Only warn when removing an unassigned public IP</title>
<updated>2026-04-16T23:09:33+00:00</updated>
<author>
<name>Martin Schwenke</name>
<email>mschwenke@ddn.com</email>
</author>
<published>2026-04-09T02:15:33+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=6c34092c76e026759e33f5425176c1b51706c10c'/>
<id>6c34092c76e026759e33f5425176c1b51706c10c</id>
<content type='text'>
get_iface_ip_maskbits() now sets iface="" when the IP is unassigned,
allowing dependent code to be conditional.

Currently, ctdb_takeover.c:ctdb_control_release_ip() ensures no
releaseip event is triggered if the public address is not on the node.
So, no change of behaviour for releaseip.

The previous attempt at making updateip behave more like takeip when
the IP isn't currently assigned caused commands with missing mask bits
to be run.  Avoid this.

Best reviewed with "git show -w" or similar.

Signed-off-by: Martin Schwenke &lt;mschwenke@ddn.com&gt;
Reviewed-by: John Mulligan &lt;jmulligan@redhat.com&gt;</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
get_iface_ip_maskbits() now sets iface="" when the IP is unassigned,
allowing dependent code to be conditional.

Currently, ctdb_takeover.c:ctdb_control_release_ip() ensures no
releaseip event is triggered if the public address is not on the node.
So, no change of behaviour for releaseip.

The previous attempt at making updateip behave more like takeip when
the IP isn't currently assigned caused commands with missing mask bits
to be run.  Avoid this.

Best reviewed with "git show -w" or similar.

Signed-off-by: Martin Schwenke &lt;mschwenke@ddn.com&gt;
Reviewed-by: John Mulligan &lt;jmulligan@redhat.com&gt;</pre>
</div>
</content>
</entry>
<entry>
<title>ctdb-tests: Tweak some NFS monitoring tests for portability</title>
<updated>2026-03-18T12:33:13+00:00</updated>
<author>
<name>Martin Schwenke</name>
<email>mschwenke@ddn.com</email>
</author>
<published>2026-03-13T06:38:43+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=460027e20031eb6a9b0582ff1f95a60b06ba6bbe'/>
<id>460027e20031eb6a9b0582ff1f95a60b06ba6bbe</id>
<content type='text'>
FreeBSD doesn't have an option to print time in nanoseconds.

We need to run something to produce fake "statistics" that are
guaranteed to change.  I think this will do - the chances of getting
the same 256 bytes twice in a row seems small enough.

Signed-off-by: Martin Schwenke &lt;mschwenke@ddn.com&gt;
Reviewed-by: Anoop C S &lt;anoopcs@samba.org&gt;

Autobuild-User(master): Martin Schwenke &lt;martins@samba.org&gt;
Autobuild-Date(master): Wed Mar 18 12:33:13 UTC 2026 on atb-devel-224
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
FreeBSD doesn't have an option to print time in nanoseconds.

We need to run something to produce fake "statistics" that are
guaranteed to change.  I think this will do - the chances of getting
the same 256 bytes twice in a row seems small enough.

Signed-off-by: Martin Schwenke &lt;mschwenke@ddn.com&gt;
Reviewed-by: Anoop C S &lt;anoopcs@samba.org&gt;

Autobuild-User(master): Martin Schwenke &lt;martins@samba.org&gt;
Autobuild-Date(master): Wed Mar 18 12:33:13 UTC 2026 on atb-devel-224
</pre>
</div>
</content>
</entry>
<entry>
<title>ctdb-tests: Skip statd-callout tests on FreeBSD</title>
<updated>2026-03-18T11:20:37+00:00</updated>
<author>
<name>Martin Schwenke</name>
<email>mschwenke@ddn.com</email>
</author>
<published>2026-03-13T06:32:42+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=acf9eaef9f6577a9406816d92fefd8974e53cb17'/>
<id>acf9eaef9f6577a9406816d92fefd8974e53cb17</id>
<content type='text'>
NFS is probably wildly different on FreeBSD and statd_callout_helper
uses chown with the --reference option.  Too hard.

Signed-off-by: Martin Schwenke &lt;mschwenke@ddn.com&gt;
Reviewed-by: Anoop C S &lt;anoopcs@samba.org&gt;</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
NFS is probably wildly different on FreeBSD and statd_callout_helper
uses chown with the --reference option.  Too hard.

Signed-off-by: Martin Schwenke &lt;mschwenke@ddn.com&gt;
Reviewed-by: Anoop C S &lt;anoopcs@samba.org&gt;</pre>
</div>
</content>
</entry>
<entry>
<title>ctdb-tests: Update README</title>
<updated>2026-02-25T12:33:39+00:00</updated>
<author>
<name>Martin Schwenke</name>
<email>mschwenke@ddn.com</email>
</author>
<published>2026-01-08T04:21:15+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=d94ffa0dde791bd00c6762cb16ef8bba8d25f054'/>
<id>d94ffa0dde791bd00c6762cb16ef8bba8d25f054</id>
<content type='text'>
Signed-off-by: Martin Schwenke &lt;mschwenke@ddn.com&gt;
Reviewed-by: Anoop C S &lt;anoopcs@samba.org&gt;</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Martin Schwenke &lt;mschwenke@ddn.com&gt;
Reviewed-by: Anoop C S &lt;anoopcs@samba.org&gt;</pre>
</div>
</content>
</entry>
<entry>
<title>ctdb-tests: Reorder and group script variables, add comments</title>
<updated>2026-02-25T12:33:39+00:00</updated>
<author>
<name>Martin Schwenke</name>
<email>mschwenke@ddn.com</email>
</author>
<published>2025-10-31T03:46:23+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=369ba7c270b3fce87fd06e55237424395a6378d4'/>
<id>369ba7c270b3fce87fd06e55237424395a6378d4</id>
<content type='text'>
Signed-off-by: Martin Schwenke &lt;mschwenke@ddn.com&gt;
Reviewed-by: Anoop C S &lt;anoopcs@samba.org&gt;</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Martin Schwenke &lt;mschwenke@ddn.com&gt;
Reviewed-by: Anoop C S &lt;anoopcs@samba.org&gt;</pre>
</div>
</content>
</entry>
</feed>
