samba.git/ctdb/tools/onnode, branch master

ctdb-tools: Avoid ShellCheck warning SC2317

2023-07-05T11:18:37+00:00

New in ShellCheck 0.9.0:

  SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).

Signed-off-by: Martin Schwenke 
Reviewed-by: Andreas Schneider

ctdb-scripts: Avoid ShellCheck warning SC2295

2022-07-22T16:09:31+00:00

For example:

In /home/martins/samba/samba/ctdb/tools/onnode line 304:
    [ "$nodes" != "${nodes%[ ${nl}]*}" ] && verbose=true
                             ^---^ SC2295 (info): Expansions inside ${..} need to be quoted separately, otherwise they match as patterns.

Did you mean:
    [ "$nodes" != "${nodes%[ "${nl}"]*}" ] && verbose=true

For more information:
  https://www.shellcheck.net/wiki/SC2295 -- Expansions inside ${..} need to b...

Who knew?  Thanks ShellCheck!

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-tools: Improve onnode's ShellCheck credibility

2020-07-16T06:51:47+00:00

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs 

Autobuild-User(master): Amitay Isaacs 
Autobuild-Date(master): Thu Jul 16 06:51:47 UTC 2020 on sn-devel-184

ctdb-tools: Allow onnode -P to respect ONNODE_SSH

2020-07-16T05:28:42+00:00

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-tools: Whitespace fixups

2020-07-16T05:28:42+00:00

Drop some unnecessary whitespace and re-indent push().

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-tools: Drop undocumented ONNODE_SSH_OPTS variable

2020-07-16T05:28:42+00:00

Options can be set in ONNODE_SSH, so this variable is unnecessary.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-scripts: Silence shellcheck warning SC2166

2019-09-17T04:35:27+00:00

This covers the following:

  SC2166: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
  SC2166: Prefer [ p ] || [ q ] as [ p -o q ] is not well defined.

POSIX agrees that -a and -o should not be used:

  https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html

Fixing these doesn't cause much churn.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-tools: Drop 'o' option from getopts command

2019-08-14T09:11:34+00:00

Commit 90de5e0594b9180226b9a13293afe31f18576b3d remove the processing
for this option but forgot to remove it from the getopts command.

Versions of ShellCheck >= 0.4.7 warn on this, so it is worth fixing.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14086
RN: Fix onnode test failure with ShellCheck >= 0.4.7
Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-tools: Drop separate parallel+verbose stdout/stderr filtering

2019-07-05T05:03:22+00:00

This has been broken for 10 years since commit
9616959bd6938e4c5c3713fe986c1e17cbdc574c, which introduced the
separate filtering.  This commit was missing a redirect of the output
of stderr_filter() to stderr.

Since nobody depends on the separate filtering (i.e. nobody reported a
bug), just return to combining stdout and stderr, and filtering them
together.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-tools: Drop no-op stdout-filter from non-parallel case

2019-07-05T05:03:22+00:00

This filter no longer does anything useful in this context.  By
default it adds a pipeline with trailing cat process.  In many
contexts, stdout of the process being run is still open so the cat
process will stay around and will stop onnode from exiting.

The filters should all go away because they are simply an example of
code that is trying to be too clever while causing unfortunate corner
cases.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs