samba.git/ctdb/tools/onnode, branch talloc-2.2.0

ctdb-tools: Detect unknown node number

2018-11-06T06:16:14+00:00

If there aren't enough addresses in the list then the shift will
silently fail and the printed address will be the unshifted value of
$1, which is incorrect/unexpected.  So, sanity check the node number.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-tools: Have onnode pass -n option even when regular ssh not in use

2018-10-08T00:46:23+00:00

ONNODE_SSH is really a test hook, so it doesn't need to support
completely random values.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-tools: Avoid use of non-portable getopt in onnode

2018-07-28T01:50:10+00:00

getopt is being used with non-portable options.  Use simpler,
POSIX-compliant getopts instead.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-tools: Improve portability by not using /bin/bash directly

2018-07-28T01:50:10+00:00

FreeBSD and others do not have /bin/bash, so use "/usr/bin/env bash"
for better flexibility.

There are still many integration tests that use /bin/bash but this at
least lets FreeBSD start running tests.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-scripts: Don't load CTDB configuration in onnode

2018-05-12T04:11:17+00:00

onnode does not use any configuration options.

Drop sourcing of functions file since the only function used was
loadconfig().

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-tools: Avoid filtering stderr when onnode not running in parallel

2018-04-27T04:53:16+00:00

stderr_filter() only does anything useful when running in
parallel (i.e. with the -p option).  So, simplify the non-parallel
case by not using stderr_filter().

As a side-effect, this fixes an issue introduced in commit
85a4375788d8ef8345ec390807f18299abdadb20 where local daemon tests
would hang when trying to start daemons with VALGRIND set (to a
valgrind command that does not use --log-file).  This is because
valgrind would keep stderr open for its output so the pipeline
involving stderr_filter() would never complete.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-scripts: Split CTDB configuration loading

2018-03-28T00:57:20+00:00

loadconfig() currently tries to load the CTDB configuration and also
any system configuration relevant to the current (event) script.

Instead add a new function load_system_config() to load the
distribution-specific system configuration for a component.  Call this
directly in the rare scripts that need the system configuration.

Also call load_system_config when loading the CTDB configuration to
pull in anything from the CTDB system configuration.  This is partly
for backward compatibility but also to get options that can be used
anywhere.

loadconfig() no longer takes an argument.  It simply loads the CTDB
configuration.

Drop support for falling back to /etc/ctdb/sysconfig/ctdb (or
similar).  Surely there's nobody who uses that!

Also, drop the indirection where loadconfig() calls _loadconfig().
This was used years ago as a test hook and is no longer required.

Inexplicably, this change introduces a new shellcheck test failure, so
silence this.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-scripts: Drop CTDB_NODES configuration option

2018-03-19T01:23:20+00:00

Tests now deviate from the compile-time default by setting CTDB_BASE.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-tools: Drop onnode CTDB_NODES_FILE environment variable

2018-03-19T01:23:19+00:00

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-tools: Reindent parts of onnode

2018-03-01T18:39:15+00:00

No functional changes.  Best viewed with diff/show -w to avoid
whitespace differences.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs