samba.git/ctdb/utils, branch talloc-2.3.1 Unnamed repository; edit this file 'description' to name the repository. ctdb/utils/smnotify/smnotify.c: typo fixes 2019-10-31T00:43:39+00:00 Björn Jacke bj@sernet.de 2019-10-26T00:41:09+00:00 a456c2bb02af56ab3d966d673421aab976e632ad Signed-off-by: Bjoern Jacke <bjacke@samba.org> Reviewed-by: Martin Schwenke <martin@meltin.net> 
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
ctdb/utils/scsi_io/scsi_io.c: typo fixes 2019-10-31T00:43:39+00:00 Björn Jacke bj@sernet.de 2019-10-26T00:41:09+00:00 1e73161bdd791fe97053dc2faa85b28e7ef55327 Signed-off-by: Bjoern Jacke <bjacke@samba.org> Reviewed-by: Martin Schwenke <martin@meltin.net> 
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
ctdb-utils: CID 1273087 - Resource leak 2019-09-17T04:35:26+00:00 Martin Schwenke martin@meltin.net 2019-07-03T10:40:44+00:00 597039daeb88f6d97f71ecaaa55efd7e091638ea Ensure that p is not leaked. This is a test program and the program exits anyway. No need to backport. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
Ensure that p is not leaked.

This is a test program and the program exits anyway.  No need to
backport.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb-utils: Fix CID 1125558 (Unchecked return value from library) 2019-06-05T12:09:56+00:00 Martin Schwenke martin@meltin.net 2019-05-29T09:11:51+00:00 952437b1bdbe000c217836c4ecd59406e92146d7 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> Autobuild-User(master): Amitay Isaacs <amitay@samba.org> Autobuild-Date(master): Wed Jun 5 12:09:56 UTC 2019 on sn-devel-184 
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Wed Jun  5 12:09:56 UTC 2019 on sn-devel-184
ctdb-utils: Avoid warning about unused value 2019-06-05T10:25:50+00:00 Martin Schwenke martin@meltin.net 2019-05-30T05:32:03+00:00 0bd87d75c0db076e17d2d186afbdccb3e769b125 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb_mutex_ceph_rados_helper: revert strtoull_err() usage 2019-03-01T18:34:18+00:00 David Disseldorp ddiss@samba.org 2019-03-01T15:40:50+00:00 e7351603890c62829f3e33a9dd471ea373a6c470 Compilation currently fails, as ctdb_mutex_ceph_rados_helper doesn't include or link against the samba-util library. Revert back to the previous strtoull() behaviour, which works fine. Signed-off-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Fri Mar 1 18:34:18 UTC 2019 on sn-devel-144 
Compilation currently fails, as ctdb_mutex_ceph_rados_helper doesn't
include or link against the samba-util library. Revert back to the
previous strtoull() behaviour, which works fine.

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Mar  1 18:34:18 UTC 2019 on sn-devel-144
ctdb-utils: Use wrapper for string to integer conversion 2019-03-01T00:32:11+00:00 Swen Schillig swen@linux.ibm.com 2019-01-30T09:28:52+00:00 fa2c919e1d05a2033ce1cb41a86f8bdd789d68b8 In order to detect an value overflow error during the string to integer conversion with strtoul/strtoull, the errno variable must be set to zero before the execution and checked after the conversion is performed. This is achieved by using the wrapper function strtoul_err and strtoull_err. Signed-off-by: Swen Schillig <swen@linux.ibm.com> Reviewed-by: Ralph Böhme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> 
In order to detect an value overflow error during
the string to integer conversion with strtoul/strtoull,
the errno variable must be set to zero before the execution and
checked after the conversion is performed. This is achieved by
using the wrapper function strtoul_err and strtoull_err.

Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Ralph Böhme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
ctdb: add expiry test for ctdb_mutex_ceph_rados_helper 2018-08-09T14:26:36+00:00 David Disseldorp ddiss@samba.org 2018-07-20T15:20:08+00:00 4abf348ec4cbb78d3216d5e8c5f3020d4499f10a Kill the ctdb_mutex_ceph_rados_helper with SIGKILL and then confirm that the lock is automatically released following expiry. Signed-off-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Samuel Cabrero <scabrero@suse.de> Reviewed-by: Amitay Isaacs <amitay@gmail.com> Autobuild-User(master): David Disseldorp <ddiss@samba.org> Autobuild-Date(master): Thu Aug 9 16:26:36 CEST 2018 on sn-devel-144 
Kill the ctdb_mutex_ceph_rados_helper with SIGKILL and then confirm
that the lock is automatically released following expiry.

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Thu Aug  9 16:26:36 CEST 2018 on sn-devel-144
ctdb_mutex_ceph_rados_helper: fix deadlock via lock renewals 2018-08-09T11:29:15+00:00 David Disseldorp ddiss@samba.org 2018-07-19T09:55:23+00:00 ce289e89e5c469cf2c5626dc7f2666b945dba3bd RADOS locks without expiry persist indefinitely. This results in CTDB deadlock during failover if the recovery master dies unexpectedly, as subsequently elected recovery master nodes can't obtain the recovery lock. Avoid deadlock by using a lock expiration time (10s by default), and renewing it periodically. Bug: https://bugzilla.samba.org/show_bug.cgi?id=13540 Signed-off-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Samuel Cabrero <scabrero@suse.de> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
RADOS locks without expiry persist indefinitely. This results in CTDB
deadlock during failover if the recovery master dies unexpectedly, as
subsequently elected recovery master nodes can't obtain the recovery
lock.
Avoid deadlock by using a lock expiration time (10s by default), and
renewing it periodically.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13540

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb_mutex_ceph_rados_helper: rename timer_ev to ppid_timer_ev 2018-08-09T11:29:15+00:00 David Disseldorp ddiss@samba.org 2018-07-17T21:36:36+00:00 91a89c146453ca203a83dc2ba555bb93276c4d7f In preparation for adding a lock refresh timer. Signed-off-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Samuel Cabrero <scabrero@suse.de> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
In preparation for adding a lock refresh timer.

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>