samba.git/ctdb/utils, branch talloc-2.3.4

ctdb-config: [cluster] recovery lock -> [cluster] cluster lock

2022-01-17T10:21:33+00:00

Retain "recovery lock" and mark as deprecated for backward
compatibility.

Some documentation is still inconsistent.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb:utils: Improve error handling of hex_decode()

2022-01-10T23:31:33+00:00

This has been found by covscan and make analyzers happy.

Pair-programmed-with: Andreas Schneider 

Signed-off-by: Pavel Filipenský 
Signed-off-by: Andreas Schneider 
Reviewed-by: Jeremy Allison

utils: Avoid pylint warning

2021-07-20T05:29:18+00:00

pylint warns:

  Use lazy % formatting in logging functions

Signed-off-by: Martin Schwenke 
Reviewed-by: David Disseldorp 
Reviewed-by: Jose A. Rivera 

Autobuild-User(master): Martin Schwenke 
Autobuild-Date(master): Tue Jul 20 05:29:18 UTC 2021 on sn-devel-184

utils: Reformat lines that are longer than 80 columns

2021-07-20T04:43:37+00:00

Signed-off-by: Martin Schwenke 
Reviewed-by: David Disseldorp 
Reviewed-by: Jose A. Rivera

utils: Tweak exception handling to stop flake8 complaining

2021-07-20T04:43:37+00:00

Don't bother with "as e" to avoid warning about unused variable.
Don't use bare "except:" (though pylint still complains about this
version).

Signed-off-by: Martin Schwenke 
Reviewed-by: David Disseldorp 
Reviewed-by: Jose A. Rivera

utils: Simplify log level logic, drop global variable

2021-07-20T04:43:37+00:00

Signed-off-by: Martin Schwenke 
Reviewed-by: David Disseldorp 
Reviewed-by: Jose A. Rivera

utils: Inline defaults and help strings

2021-07-20T04:43:37+00:00

Removes an unnecessary level of indirection: defaults and help strings
are now where they are expected.  Also removes some global variables.

Signed-off-by: Martin Schwenke 
Reviewed-by: David Disseldorp 
Reviewed-by: Jose A. Rivera

utils: Move argument processing into function and call from main()

2021-07-20T04:43:37+00:00

Removes the need for the global variables currently associated with
this processing.  Also removes unnecessarily double-handling the
defaults, which are assigned to the global variables and set via
add_argument().

Signed-off-by: Martin Schwenke 
Reviewed-by: David Disseldorp 
Reviewed-by: Jose A. Rivera

utils: Reorder imports so that standard imports are first

2021-07-20T04:43:37+00:00

Avoids numerous pylint warnings.

Signed-off-by: Martin Schwenke 
Reviewed-by: David Disseldorp 
Reviewed-by: Jose A. Rivera

utils: Clean up ctdb_etcd_lock using autopep8

2021-07-20T04:43:37+00:00

Signed-off-by: Martin Schwenke 
Reviewed-by: David Disseldorp 
Reviewed-by: Jose A. Rivera