samba.git/ctdb, branch master

ctdb-scripts: Support interface altnames

2026-04-17T00:11:50+00:00

This avoids generating a warning like:

  WARNING: Public IP  hosted on interface  but VNN says 

every time a public IP is removed from an interface that is configured
via an altname.

The new check will nearly always be successful because the IP will be
on the expected interface during releaseip/updateip.

The original check is now used as a backup when the IP is not on the
expected interface.  To allow the mask bits check to cover both cases,
the original check and the associated interface check needs to be
inside the else clause.

Update the unit test to reflect the change.

Best reviewed with "git show -w" or similar.

Signed-off-by: Martin Schwenke 
Reviewed-by: John Mulligan 

Autobuild-User(master): Martin Schwenke 
Autobuild-Date(master): Fri Apr 17 00:11:50 UTC 2026 on atb-devel-224

ctdb-tests: Add addip/releaseip altname unit test

2026-04-16T23:09:33+00:00

This shows that a warning is generated whenever an IP address is
removed using an altname.

Signed-off-by: Martin Schwenke 
Reviewed-by: John Mulligan

ctdb-tests: Implement altname property for ip link/addr

2026-04-16T23:09:33+00:00

Only implemented for these commands.  I don't even want to think about
doing this for ip route right now.

Signed-off-by: Martin Schwenke 
Reviewed-by: John Mulligan

ctdb-scripts: Rename/reimplement get_iface_ip_maskbits()

2026-04-16T23:09:33+00:00

Reimplement to set prefix instead of maskbits.  Rename to
get_ip_prefix_iface().

Signed-off-by: Martin Schwenke 
Reviewed-by: John Mulligan

ctdb-scripts: Add function ip_prefix_iface()

2026-04-16T23:09:33+00:00

Reimplement ip_maskbits_iface() using the ip -brief option.  Do less
parsing, no longer extract maskbits but return whole prefix.

Retain ip_maskbits_iface() for backward compatibility in case custom
event scripts are using it.

Signed-off-by: Martin Schwenke 
Reviewed-by: John Mulligan

ctdb-tests: Implement -brief option for ip addr show stub

2026-04-16T23:09:33+00:00

Signed-off-by: Martin Schwenke 
Reviewed-by: John Mulligan

ctdb-tests: Fix a typo in "ip link show" stub output

2026-04-16T23:09:33+00:00

Status is different to state and should not be repeated.  For example:

eth0             UP             aa:bb:cc:dd:ee:ff 

Clearly nothing looks at this field but it should be correct.

Signed-off-by: Martin Schwenke 
Reviewed-by: John Mulligan

ctdb-scripts: Drop full address prefix lengths

2026-04-16T23:09:33+00:00

ip addr assumes these defaults anyway.  They are just noise.

Signed-off-by: Martin Schwenke 
Reviewed-by: John Mulligan

ctdb-scripts: Add an extra variable to help reviewers

2026-04-16T23:09:33+00:00

Using $_bcast to determine if the address is an IPv6 one is lazy.  It
causes anyone reading the code (including the original author) to have
to go back and confirm that the condition makes sense.

Signed-off-by: Martin Schwenke 
Reviewed-by: John Mulligan

ctdb-scripts: Add function ip_addr_add()

2026-04-16T23:09:33+00:00

For consistency with new ip_addr_del().

Update all callers of add_ip_to_iface() to use this function
instead.

Retain add_ip_to_iface() for backward compatibility in case custom
event scripts are using it.

Signed-off-by: Martin Schwenke 
Reviewed-by: John Mulligan