samba.git/ctdb, branch talloc-2.1.2

ctdb-tests: Check for readable, not executable, script

2015-03-06T03:40:07+00:00

Scripts in eventscript unit tests are run under an explicitly
specified shell so they do not need to be executable.  Checking that
the script is executable breaks on scripts that are installed without
the execute bit set, such as disabled eventscripts.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs 

Autobuild-User(master): Amitay Isaacs 
Autobuild-Date(master): Fri Mar  6 04:40:07 CET 2015 on sn-devel-104

ctdb-locking: Back-off from logging every 10 seconds

2015-03-05T11:06:44+00:00

If ctdb_lock_helper cannot get a lock within 10 seconds, ctdb daemon
logs a message and invokes an external debug script.  This is repeated
every 10 seconds.

In case of a contention or on a loaded system, there can be multiple
ctdb_lock_helper processes waiting to get lock on record(s).  For each
lock request taking longer, ctdb daemon will flood the log every
10 seconds.  Instead of logging aggressively every 10 seconds, relax
logging to every 100s and 1000s if the elapsed time has exceeded 100s
and 1000s respectively.

Signed-off-by: Amitay Isaacs 
Reviewed-by: Michael Adam 

Autobuild-User(master): Michael Adam 
Autobuild-Date(master): Thu Mar  5 12:06:44 CET 2015 on sn-devel-104

ctdb-tests: Correctly cascade test failures from the end of pipes

2015-03-05T06:16:54+00:00

Some eventscript unit test failures get lost because _passed=false is
set in the tail of a pipe.  Add a new function test_fail() and call it
when necessary to ensure the value of _passed is set correctly.

Signed-off-by: Amitay Isaacs 
Pair-programmed-by: Martin Schwenke 
Reviewed-by: Martin Schwenke 

Autobuild-User(master): Martin Schwenke 
Autobuild-Date(master): Thu Mar  5 07:16:54 CET 2015 on sn-devel-104

ctdb-scripts: Add a 'rm' stub so statd-callout tests work correctly

2015-03-05T03:46:06+00:00

statd-callout tries to remove global files from /var/lib/nfs/statd and
this causes errors in tests.  Add an rm stub that ignores attempts to
remove these files but invokes /bin/rm for anything else.

Signed-off-by: Amitay Isaacs 
Pair-programmed-by: Martin Schwenke 
Reviewed-by: Martin Schwenke

ctdb-build: Specify absolute path to libsocket-wrapper.so

2015-03-04T12:11:53+00:00

Specifying a relative path to LD_PRELOAD can fail if any of the test
scripts uses cd to change directory and execute commands.

Adding statd-callout tests breaks autotest since statd-callout does "cd".

Signed-off-by: Amitay Isaacs 
Reviewed-by: Martin Schwenke 

Autobuild-User(master): Amitay Isaacs 
Autobuild-Date(master): Wed Mar  4 13:11:53 CET 2015 on sn-devel-104

ctdb-tests: Remove the old, confusing INSTALL script

2015-03-04T09:42:27+00:00

It is not used after switching to waf build.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-scripts: Remove unused function nfs_statd_update()

2015-03-04T09:42:27+00:00

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-scripts: Change statd-callout to be more scalable

2015-03-04T09:42:27+00:00

Updating ctdb.tdb on each add-client, del-client and each delete
during notify was too ambitious.  Persistent transactions do not
perform well enough to do this.

Revert to having add-client and del-client create touch files.  Each
monitor event calls "statd-callout update" to convert touch files into
ctdb.tdb records.

Update testcases to do the "update" and add an extra test.

Signed-off-by: Martin Schwenke 
Pair-programmed-with: Amitay Isaacs 
Reviewed-by: Amitay Isaacs

ctdb-scripts: Fix a regression in statd-callout

2015-03-04T09:42:27+00:00

Commit 4638010abb116aed0c180207aaa11475277aecb7 changed from using
gensub() to gsub() in awk.  However, it didn't halve the number of
backslashes in the target strings.  This is necessary because
backslash is used in gensub() target strings to allow substitution of
text matching parenthesised subexpressions.  This is not the case with
gsub().

So, halve the number of backslashes in the target string where gsub()
is used in statd-callout.  This is the only target string broken by
changes made by the above commit

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-tests: Unit tests for statd-callout

2015-03-04T09:42:27+00:00

With improvements to unit test infrastructure to support.  This
includes linking the real statd-callout into etc-ctdb/ in place of the
placeholder script.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs