samba.git/ctdb, branch talloc-2.3.0 Unnamed repository; edit this file 'description' to name the repository. ctdb-tools: CID 1449530 - Negative loop bound 2019-07-05T06:49:16+00:00 Martin Schwenke martin@meltin.net 2019-07-03T10:58:54+00:00 753874b38fddc05357635e13c8ce26d319b0d77f Regression introduced by commit 2558f96da1f9be8034f26736c8050bb38a1f82a8. count should be signed because list_of_connected_nodes() returns -1 on failure. Variable i is used in both signed and unsigned contexts, so add new signed variable j for use in signed context. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
Regression introduced by commit
2558f96da1f9be8034f26736c8050bb38a1f82a8.  count should be signed
because list_of_connected_nodes() returns -1 on failure.  Variable i
is used in both signed and unsigned contexts, so add new signed
variable j for use in signed context.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb-config: depend on /etc/ctdb/nodes file 2019-07-05T06:49:16+00:00 Rafael David Tinoco rafaeldtinoco@ubuntu.com 2019-06-27T20:12:25+00:00 c5803507df7def388edcd5b6cbfee30cd217b536 BUG: https://bugzilla.samba.org/show_bug.cgi?id=14017 CTDB should start as a disabled unit (systemd) in most of the distributions and, when trying to enable it for the first time, user should get an unconfigured, or similar, error. Depending on /etc/ctdb/nodes file will give a clear direction to final user on what is needed in order to get cluster up and running. It should work like previous ENABLED=NO variables in SySV like initialization scripts. Signed-off-by: Rafael David Tinoco <rafaeldtinoco@ubuntu.com> Reviewed-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14017

CTDB should start as a disabled unit (systemd) in most of the
distributions and, when trying to enable it for the first time, user
should get an unconfigured, or similar, error.

Depending on /etc/ctdb/nodes file will give a clear direction to final
user on what is needed in order to get cluster up and running. It should
work like previous ENABLED=NO variables in SySV like initialization
scripts.

Signed-off-by: Rafael David Tinoco <rafaeldtinoco@ubuntu.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb-tests: Rename local-daemon.sh dump-logs to print-log 2019-07-05T06:19:11+00:00 Martin Schwenke martin@meltin.net 2019-06-30T21:04:19+00:00 a0561c7ed44afcc978f940a7936a210f37baf273 This makes it consistent with print-socket. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> Autobuild-User(master): Amitay Isaacs <amitay@samba.org> Autobuild-Date(master): Fri Jul 5 06:19:11 UTC 2019 on sn-devel-184 
This makes it consistent with print-socket.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Fri Jul  5 06:19:11 UTC 2019 on sn-devel-184
ctdb-build: Tweak hacking of rpcgen output 2019-07-05T05:03:25+00:00 Martin Schwenke martin@meltin.net 2019-06-25T00:03:44+00:00 e0b33c5549ffb1a06270af5e2b4a199496add90d csbuild doesn't like the hack where variable buf is initialised to itself to avoid an unused variable warning. buf is unused so remove it instead. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
csbuild doesn't like the hack where variable buf is initialised to
itself to avoid an unused variable warning.  buf is unused so remove
it instead.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb-daemon: Don't check if lock_ctx->ctdb_db is NULL 2019-07-05T05:03:25+00:00 Martin Schwenke martin@meltin.net 2019-06-24T20:35:04+00:00 755a9e654feaa7265975a1f02ea2f59fd30d09a9 This can never be NULL. It could probably be NULL in the past when "all database" locks existed. There are paths where is is checked for NULL and then later dereferenced, causing static analysers to produce spurious warnings. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
This can never be NULL.  It could probably be NULL in the past when
"all database" locks existed.

There are paths where is is checked for NULL and then later
dereferenced, causing static analysers to produce spurious warnings.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb-common: Mark ctdb_fatal() and ctdb_die() as _NORETURN_ 2019-07-05T05:03:24+00:00 Martin Schwenke martin@meltin.net 2019-06-24T07:01:07+00:00 e5a946cba5c309a6bdd1109685866d4a1c6841be This avoids static analysers continuing analysis after calls to these functions and producing incorrect warnings. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
This avoids static analysers continuing analysis after calls to these
functions and producing incorrect warnings.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb-event: Fix signed/unsigned comparisons by casting 2019-07-05T05:03:24+00:00 Martin Schwenke martin@meltin.net 2019-06-24T06:45:06+00:00 ba95cb2ae1564edc27541c2a87e35f338e4653f7 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb-database: Fix signed/unsigned comparison by casting 2019-07-05T05:03:24+00:00 Martin Schwenke martin@meltin.net 2019-06-24T06:44:37+00:00 5527f3922fd680a9bd8330434a0c4221f35e51aa Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb-event: Assign missing return value 2019-07-05T05:03:24+00:00 Martin Schwenke martin@meltin.net 2019-06-24T06:42:58+00:00 e7b586f711f739cf50e9a623c683b23856266eed Otherwise ret == 0 is returned from successful call to ctdb_int32_pull(). Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
Otherwise ret == 0 is returned from successful call to
ctdb_int32_pull().

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb-common: Fix signed/unsigned comparisons by declaring as unsigned 2019-07-05T05:03:24+00:00 Martin Schwenke martin@meltin.net 2019-06-24T06:42:21+00:00 d424d2197f1f873fded84ed650295d0b8c64960a Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> 
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>