samba.git/ctdb, branch talloc-2.3.1

ctdb-tests: Add tests for cmdline_add() api

2019-11-14T12:03:46+00:00

Signed-off-by: Amitay Isaacs 
Reviewed-by: Martin Schwenke 

Autobuild-User(master): Martin Schwenke 
Autobuild-Date(master): Thu Nov 14 12:03:46 UTC 2019 on sn-devel-184

ctdb-common: Add api to add new section/commands to cmdline

2019-11-14T10:38:34+00:00

Signed-off-by: Amitay Isaacs 
Reviewed-by: Martin Schwenke

ctdb-common: Change cmdline implementation to support multiple sections

2019-11-14T10:38:34+00:00

Signed-off-by: Amitay Isaacs 
Reviewed-by: Martin Schwenke

ctdb-tests: Update cmdline tests for section name

2019-11-14T10:38:34+00:00

Signed-off-by: Amitay Isaacs 
Reviewed-by: Martin Schwenke

ctdb-common: Add section to group commands in cmdline

2019-11-14T10:38:34+00:00

Signed-off-by: Amitay Isaacs 
Reviewed-by: Martin Schwenke

ctdb-common: Generate usage message from cmdline_parse()

2019-11-14T10:38:34+00:00

If any of the option parsing or command parsing fails, generate usage
message.

Signed-off-by: Amitay Isaacs 
Reviewed-by: Martin Schwenke

ctdb-tcp: Simplify freeing of transport data on shutdown

2019-11-14T03:45:44+00:00

The type-checking is superfluous and gets in the way of readability.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs 

Autobuild-User(master): Amitay Isaacs 
Autobuild-Date(master): Thu Nov 14 03:45:44 UTC 2019 on sn-devel-184

ctdb-daemon: Rename ctdb_context private_data to transport_data

2019-11-14T02:20:46+00:00

This gives a casual reader a useful clue.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-daemon: Rename ctdb_node private_data to transport_data

2019-11-14T02:20:46+00:00

This gives a casual reader a useful clue.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-tcp: Close inflight connecting TCP sockets after fork

2019-11-14T02:20:46+00:00

Commit c68b6f96f26 changed the talloc hierarchy such that outgoing TCP sockets
while sitting in the async connect() syscall are not freed via
ctdb_tcp_shutdown() anymore, they are hanging off a longer-running structure.
Free this structure as well.

If an outgoing TCP socket leaks into a long-running child process (possibly the
recovery daemon), this connection will never be closed as seen by the
destination node. Because with recent changes incoming connections will not be
accepted as long as any incoming connection is alive, with that socket leak
into the recovery daemon we will never again be able to successfully connect to
the node that is affected by this leak. Further attempts to connect will be
discarded by the destination as long as the recovery daemon keeps this socket
alive.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14175
RN: Avoid communication breakdown on node reconnect

Signed-off-by: Martin Schwenke 
Signed-off-by: Volker Lendecke 
Reviewed-by: Amitay Isaacs