samba.git/ctdb, branch talloc-2.3.3

ctdb-scripts: Ignore ShellCheck SC3013 for test -nt

2021-06-25T10:06:48+00:00

In ShellCheck 0.7.2, POSIX compatibility warnings got their own SC3xxx
error codes, so now both the old and new codes need to be ignored.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs 

Autobuild-User(master): Amitay Isaacs 
Autobuild-Date(master): Fri Jun 25 10:06:48 UTC 2021 on sn-devel-184

ctdb-tests: Force stub version of service in eventscript tests

2021-06-25T09:16:31+00:00

Fedora 34 now has a shell function for the which command, which causes
these uses of which to return the enclosing function definition rather
than the executable file as expected.

The event script unit tests always expect the stub service command to
be used, so the conditional in these functions is unnecessary.
$CTDB_HELPER_BINDIR already conveniently points to the stub directory,
so use it here.

Signed-off-by: Martin Schwenke 
Signed-off-by: Amitay Isaacs

ctdb-common: Drop unused include of mkdir_p.h

2021-06-25T09:16:31+00:00

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-daemon: Close server socket when switching to client

2021-06-25T09:16:31+00:00

The socket is set close-on-exec but that doesn't help for processes
that do not exec().  This should be done for all child processes.

This has been seen in testing where "ctdb shutdown" waits for the
socket to close before succeeding.  It appears that lingering
vacuuming processes have not closed the socket when becoming clients
so they cause "ctdb shutdown" to hang even though the main daemon
process has exited.  The cause of the lingering vacuuming processes
has been previously examined but still isn't understood.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-tests: Add debug_locks.sh tests for mutexes

2021-05-28T07:34:23+00:00

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs 

Autobuild-User(master): Amitay Isaacs 
Autobuild-Date(master): Fri May 28 07:34:23 UTC 2021 on sn-devel-184

ctdb-scripts: Add lock debugging for tdb mutex locks

2021-05-28T06:46:29+00:00

Signed-off-by: Amitay Isaacs 
Signed-off-by: Martin Schwenke

ctdb-utils: Add tdb_mutex_check utility

2021-05-28T06:46:29+00:00

Signed-off-by: Amitay Isaacs 
Reviewed-by: Martin Schwenke

ctdb-scripts: Simplify logic in debug_via_proc_locks()

2021-05-28T06:46:29+00:00

The path of the TDB is known, so calculate the file ID (device number
+ inode number) from it and use this to directly filter /proc/locks to
find processes holding locks.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-scripts: Update debug_locks.sh to handle arguments

2021-05-28T06:46:29+00:00

Don't use the  arguments yet.  They will be used in a simplified
version of the code.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs

ctdb-scripts: Move current lock debugging to a function

2021-05-28T06:46:29+00:00

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs