samba.git/ctdb, branch talloc-2.4.2

ctdb: add comments to "addip"/"delip" when CTDB_{CONTROL,EVENT,SRVID}_IPREALLOCATED happens

2024-01-04T11:39:36+00:00

"addip"/"delip" are different from "moveip" so they don't need to
call ipreallocate() nor send_ipreallocated_control_to_nodes().

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Martin Schwenke

ctdb: let "moveip" end with CTDB_CONTROL_IPREALLOCATED to all connected nodes

2024-01-04T11:39:36+00:00

This matches the behavior of takeover_send/recv() from
ctdb_takeover_helper.c.

It means we consistently call the ipreallocated event scripts
and also send CTDB_SRVID_IPREALLOCATED after moving ips.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Martin Schwenke

ctdb: remove unused ctdb_message_disable_ip_check()

2024-01-04T11:39:36+00:00

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Martin Schwenke

ctdb: let "moveip" also use disable_takeover_runs()

2024-01-04T11:39:36+00:00

That makes the behavior more consistent compared to a takeover run
started from the within ctdbd.

The behavior is the same but ctdb_message_disable_ip_check() used
a legacy code path and the next commits will also touch some
of the moveip logic...

The logic and comments are copied from control_reloadips().

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Martin Schwenke

ctdb: send a CTDB_SRVID_IPREALLOCATED message after CTDB_EVENT_IPREALLOCATED

2024-01-04T11:39:36+00:00

Event scripts run the "ipreallocated" hook in order to notice that some ip addresses
in the cluster potentially changed.

CTDB_SRVID_IPREALLOCATED gives C code a chance to get notified as well once the event
scripts are finished.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Martin Schwenke

ctdb-server: Drop unnecessary copy of destination address

2023-12-15T12:09:21+00:00

Modernise debug while touching the code.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15523

Signed-off-by: Martin Schwenke 
Reviewed-by: Stefan Metzmacher 

Autobuild-User(master): Stefan Metzmacher 
Autobuild-Date(master): Fri Dec 15 12:09:21 UTC 2023 on atb-devel-224

ctdb-daemon: Use ctdb_connection_to_buf() to simplify

2023-12-15T11:06:34+00:00

The one case that is no longer handled specially is when the
destination address is IPv4 loopback.  This may previously have been
used to avoid flooding the logs when testing.  However, that seems
unnecessary - if testing with 127.0.0.1 then make it a public address.

Modernise debug while touching the code.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15523

Signed-off-by: Martin Schwenke 
Reviewed-by: Stefan Metzmacher

ctdb: add/implement CTDB_CONTROL_TCP_CLIENT_PASSED

2023-12-15T11:06:34+00:00

With multichannel a tcp connection is registered first with
a temporary smbd process, that calls CTDB_CONTROL_TCP_CLIENT
first and then passes the tcp connection to the longterm smbd
that already handles all connections belonging to the specific
client_guid. That smbd process calls CTDB_CONTROL_TCP_CLIENT
again, but the 'tickle' information is already there.
When the temporary smbd process exists/disconnects from ctdb
or calls CTDB_CONTROL_TCP_CLIENT_DISCONNECTED, the 'tickle'
information is removed, while the longterm smbd process
still serves the tcp connection.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15523

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Martin Schwenke

ctdb: add/implement CTDB_CONTROL_TCP_CLIENT_DISCONNECTED

2023-12-15T11:06:34+00:00

With multichannel a ctdb connection from smbd may hold multiple
tcp connections, which can be disconnected before the smbd
process terminates the whole ctdb connection, so we a
way to remove undo 'CTDB_CONTROL_TCP_CLIENT' again.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15523

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Martin Schwenke

ctdb: add ctdb_connection_same() helper

2023-12-15T11:06:34+00:00

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Martin Schwenke