samba.git/lib/async_req/async_sock.c, branch talloc-2.1.3

async_req: check for errors when monitoring socket for readability

2015-07-15T20:41:13+00:00

Add an option to wait_for_read_send(), so that the request, upon
calling back, report whether the socket actually contains data
or is in EOF/error state. EOF is signalled via the EPIPE error.

This is useful for clients which do not expect data to arrive but
wait for readability to detect a closed socket (i.e. they do not
intend to actually read the socket when it's readable). Actual data
arrival would indicate a bug in this case, so the check can
be used to print an error message.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11397

Signed-off-by: Uri Simchoni 
Reviewed-by: Jeremy Allison 
Reviewed-by: Volker Lendecke

lib: Fix CID 710685 Unchecked return value from library

2015-06-23T20:12:08+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

lib: Fix CID 1306765 Unchecked return value from library

2015-06-16T17:22:52+00:00

This one might be a bit controversial. I don't see from man fcntl how this
could fail. But if it does, we definitely do want to know about it. And here we
don't have any good way to tell our caller, so abort.

Signed-off-by: Volker Lendecke 
Reviewed-by: "Stefan (metze) Metzmacher" 

Autobuild-User(master): Volker Lendecke 
Autobuild-Date(master): Tue Jun 16 19:22:52 CEST 2015 on sn-devel-104

lib: Fix CID 1306764 Unchecked return value

2015-06-16T14:33:10+00:00

tevent_req_oom exists right for this case :-)

Signed-off-by: Volker Lendecke 
Reviewed-by: "Stefan (metze) Metzmacher"

lib/async_req: remove the tevent_fd as early as possible via a wait_for_read_cleanup() hook

2015-06-12T15:08:18+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11316

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Volker Lendecke

lib/async_req: remove the tevent_fd as early as possible via a read_packet_cleanup() hook

2015-06-12T15:08:18+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11316

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Volker Lendecke

lib/async_req: use tevent_req_nomem/tevent_req_post in read_packet_send()

2015-06-12T15:08:18+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11316

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Volker Lendecke

lib/async_req: s/result/req/ in read_packet_send()

2015-06-12T15:08:18+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11316

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Volker Lendecke

lib/async_req: remove the tevent_fd as early as possible via a writev_cleanup() hook

2015-06-12T15:08:18+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11316

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Volker Lendecke

lib/async_req: simplify async_connect_* using a _cleanup() hook

2015-06-12T15:08:18+00:00

This makes sure we remove the tevent_fd as soon as possible
and always reset the old_sockflags.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11316

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Volker Lendecke