samba.git/lib/async_req, branch talloc-2.3.1

lib/async_req/async_sock.c set socket close on exec

2017-12-18T03:38:19+00:00

Set SOCKET_CLOEXEC on the sockets returned by accept.  This ensures that
the socket is unavailable to any child process created by system().
Making it harder for malicious code to set up a command channel,
as seen in the exploit for CVE-2015-0240

Signed-off-by: Gary Lockyer 
Reviewed-by: Andrew Bartlett

lib: tevent: Use system , not internal header path (except in self-test).

2017-08-16T18:58:13+00:00

Signed-off-by: Jeremy Allison 
Reviewed-by: Andreas Schneider

lib/async_req: add writev_cancel()

2016-10-26T09:20:12+00:00

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andreas Schneider

async_req: make async_connect_send() "reentrant"

2016-08-04T03:03:21+00:00

Allow callers to pass in socket fds that where already passed to an
earlier call of async_connect_send(). Callers expect this behaviour and
it was working until 05d4dbda8357712cb81008e0d611fdb0e7239587 broke it.

The proper fix would be to change callers to close the fd and start from
scratch with a fresh socket.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=12105

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Ralph Böhme 
Autobuild-Date(master): Thu Aug  4 05:03:21 CEST 2016 on sn-devel-144

lib: Fix a signed/unsigned mixup

2016-06-13T08:10:11+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Andreas Schneider

lib: Add accept_send/recv

2016-06-07T12:34:10+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

lib/async_req: do not install async_connect_send_test.

2015-12-01T16:41:19+00:00

Guenther

Signed-off-by: Günther Deschner 
Reviewed-by: Ralph Boehme

selftest: Fix memset parameters in test for async_connect_send()

2015-10-21T15:31:00+00:00

This fixes:

../lib/async_req/async_connect_send_test.c: In function ‘main’:
../lib/async_req/async_connect_send_test.c:88:3: error: ‘memset’ used with constant zero length parameter; this could be due to transposed parameters [-Werror=memset-transposed-args]
   memset(&addr, sizeof(addr), 0);
   ^
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11564

Signed-off-by: Andrew Bartlett 
Reviewed-by: Ralph Boehme 

Autobuild-User(master): Ralph Böhme 
Autobuild-Date(master): Wed Oct 21 17:31:00 CEST 2015 on sn-devel-104

async_req: fix non-blocking connect()

2015-10-20T18:22:22+00:00

According to Stevens UNIX Network Programming and various other sources,
the correct handling for non-blocking connect() is:

- when the initial connect() return -1/EINPROGRESS polling the socket
  for *writeability*

- in the poll handler call getsocktopt() with SO_ERROR to get the
  finished connect() return value

Simply calling connect() a second time without error checking is
probably wrong and not portable. For a successfull connect() Linux
returns 0, but Solaris will return EISCONN:

24254:   0.0336  0.0002 connect(4, 0xFEFFECAC, 16, SOV_DEFAULT) Err#150 EINPROGRESS
24254:          AF_INET  name = 10.10.10.143  port = 1024
24254:   0.0349  0.0001 port_associate(3, 4, 0x00000004, 0x0000001D,0x080648A8) = 0
24254:   0.0495  0.0146 port_getn(3, 0xFEFFEB50, 1, 1, 0xFEFFEB60) = 1 [0]
24254:   0.0497  0.0002 connect(4, 0x080646E4, 16, SOV_DEFAULT) Err#133 EISCONN
24254:          AF_INET  name = 10.10.10.143  port = 1024

Bug: https://bugzilla.samba.org/show_bug.cgi?id=11564

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

selftest: add a test for async_connect_send()

2015-10-20T18:22:22+00:00

Bug: https://bugzilla.samba.org/show_bug.cgi?id=11564

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison