samba.git/lib/async_req, branch talloc-2.4.4

lib:async_req: Initialize variables

2025-08-27T03:41:36+00:00

../../lib/async_req/async_sock.c: In function ‘writev_do’:
../../lib/async_req/async_sock.c:360:12: error: ‘written’ may be used uninitialized [-Werror=maybe-uninitialized]
  360 |         if ((written == -1) &&
      |            ^
../../lib/async_req/async_sock.c:343:17: note: ‘written’ was declared here
  343 |         ssize_t written;
      |                 ^~~~~~~
../../lib/async_req/async_sock.c: In function ‘read_packet_do’:
../../lib/async_req/async_sock.c:563:12: error: ‘nread’ may be used uninitialized [-Werror=maybe-uninitialized]
  563 |         if ((nread == -1) && (errno == EINTR)) {
      |            ^
../../lib/async_req/async_sock.c:531:17: note: ‘nread’ was declared here
  531 |         ssize_t nread, more;
      |                 ^~~~~
cc1: all warnings being treated as errors

Signed-off-by: Jennifer Sutton 
Reviewed-by: Douglas Bagnall

async_sock: add wait_for_error_send/recv

2025-06-18T17:52:37+00:00

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Volker Lendecke

async_sock: move samba_socket_{poll,sock,poll_or_sock}_error() from util_net.c to async_sock.c

2025-06-18T17:52:37+00:00

The change to LGPL is also intended.

It will be used in the the next commit that adds
wait_for_error_send/recv.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Volker Lendecke

async_sock: try recvmsg(MSG_DONTWAIT) without fd event handler first

2025-05-12T11:28:47+00:00

Also callers typically read a header to get the length and then
the remaining data, for that we typically don't need an additional
hop via [e]poll.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Stefan Metzmacher 
Autobuild-Date(master): Mon May 12 11:28:47 UTC 2025 on atb-devel-224

async_sock: split out read_packet_do() from read_packet_handler()

2025-05-12T10:31:30+00:00

We'll call read_packet_do() in other places too in future.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Volker Lendecke

async_sock: make use of recvmsg() in read_packet_handler()

2025-05-12T10:31:30+00:00

This typically has a better call stack in the kernel.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Volker Lendecke

async_sock: let writev_do() try sendmsg() first

2025-05-12T10:31:30+00:00

This is typically more efficient on the kernel call stack.
As far as I can see writev_send/recv is only used with sockets
so far, but in any case we fallback on ENOTSOCK.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Volker Lendecke

lib: Remove an obsolete comment

2024-04-17T09:01:34+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Martin Schwenke 

Autobuild-User(master): Martin Schwenke 
Autobuild-Date(master): Wed Apr 17 09:01:34 UTC 2024 on atb-devel-224

lib/async_req: let writev_send/recv use TEVENT_FD_ERROR

2023-10-24T09:36:37+00:00

Unless err_on_readability is true, we use TEVENT_FD_READ only
to detect errors. Now that we have TEVENT_FD_ERROR we should use it.

As a side effect it makes the code much simpler and clearer, as
we can directly map TEVENT_FD_ERROR to EPIPE.

In addition the err_on_readability=true case is now also
clearer, where we just map TEVENT_FD_READ to EPIPE.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Ralph Boehme 
Reviewed-by: Andrew Bartlett

lib/async_req: let async_connect_send use TEVENT_FD_ERROR instead of TEVENT_FD_READ

2023-10-24T09:36:37+00:00

This mostly cosmetic, but now that we have TEVENT_FD_ERROR we should use it.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Ralph Boehme 
Reviewed-by: Andrew Bartlett