samba.git/lib/audit_logging/audit_logging.c, branch talloc-2.2.0

lib/audit_logging: actually create talloc

2018-12-20T02:19:28+00:00

Heal damage of 79f494e51e..

That context is being passed around and freed but is never
actually allocated on that stack.

Signed-off-by: Philipp Gesang 
Reviewed-by: Gary Lockyer 
Reviewed-by: Jeremy Allison

lib/audit_logging: Use talloc_stackframe() in audit_log_json()

2018-12-14T09:27:18+00:00

Signed-off-by: Andrew Bartlett 
Reviewed-by: Gary Lockyer

audit_logging: Remove debug log header and JSON Authentication: prefix

2018-12-14T09:27:18+00:00

Feedback from real-world users is that they really want raw JSON
strings in the log.

We can not easily remove the leading "  " but the other strings above
and before the JSON are really annoying to strip back off

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13714

Signed-off-by: Andrew Bartlett 
Reviewed-by: Gary Lockyer

audit_logging: Use dom_sid_str_buf

2018-11-02T20:21:16+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

lib/audit_logging: make json_{is_invalid,to_string}() accept a const*

2018-09-22T04:05:06+00:00

Allow for json_is_invalid() and json_to_string() to be used on a
const pointer. Neither function requires for the json object to
be mutable so constraining them to non-const* is unnecessary.

Reviewed-by: Gary Lockyer 
Signed-off-by: Philipp Gesang 
Reviewed-by: Andrew Bartlett

json: Modify API to use return codes

2018-07-25T04:29:50+00:00

Modify the auditing JSON API to return a response code, as the consensus
was that the existing error handling was aesthetically displeasing.

Signed-off-by: Gary Lockyer 
Reviewed-by: Jeremy Allison 
Reviewed-by: Andrew Bartlett

audit_logging: Remove duplciate error printing

2018-06-26T01:27:20+00:00

These errors are already logged at DBG_NOTICE in get_event_server()

Signed-off-by: Andrew Bartlett 
Reviewed-by: Gary Lockyer

audit_logging: Initialise event_server

2018-06-26T01:27:20+00:00

It is better if this is a known zero value to start, even if we check the errors
correctly.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Gary Lockyer

audit_logging: Remove incorrect check for NT_STATUS_OBJECT_NAME_NOT_FOUND

2018-06-26T01:27:20+00:00

NT_STATUS_OBJECT_NAME_NOT_FOUND is not a case we can ignore, it would mean that event_server
is not initialised.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Gary Lockyer

audit_logging: Clarify debug messages

2018-06-26T01:27:20+00:00

Signed-off-by: Andrew Bartlett 
Reviewed-by: Gary Lockyer