samba.git/lib/cmdline, branch master

lib:cmdline: Check if we have a valid default ccache

2025-08-05T10:49:34+00:00

If you don't specify anything, and we have a valid ccache then try to
use it!

> smbclient -L //samba1.earth.milkyway.site
Anonymous login successful

        Sharename       Type      Comment
        ---------       ----      -------
        print$          Disk      Printer Drivers
        IPC$            IPC       IPC Service (Samba 4.22.1)
SMB1 disabled -- no workgroup available

In case the user specifies a principal, it will ask for a password:

> bin/smbclient -L //samba1.earth.milkyway.site -Ualice1@EARTH.MILKYWAY.SITE
Password for [alice1@EARTH.MILKYWAY.SITE]:

Signed-off-by: Andreas Schneider 
Reviewed-by: Alexander Bokovoy

lib:cmdline: POPT_CALLBACK_REASON_POST should handle if we skip the password callback

2025-04-15T12:54:57+00:00

It is already checking if there is a valid ccache and disabling the callback.
In case of IAKerb we specify a ccache but might to fill one with a krbtgt.

Signed-off-by: Andreas Schneider 
Reviewed-by: Stefan Metzmacher 
Reviewed-by: Alexander Bokovoy 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Tue Apr 15 12:54:57 UTC 2025 on atb-devel-224

lib:cmdline: Make sure --use-krb5-ccache sets the ccache

2025-04-15T11:54:57+00:00

Pair-Programmed-With: Alexander Bokovoy 
Signed-off-by: Alexander Bokovoy 
Signed-off-by: Andreas Schneider 
Reviewed-by: Stefan Metzmacher

replace direct calls to memset_s() with commonly used macros

2025-01-02T17:01:30+00:00

samba provides macros for zeroing various structures in memory,
and all code uses them instead of relying on memset_s().
However, a few places use memset_s() directly.  Replace these
usages with macros for consistency and to be able to replace
memset_s() easier.

A few notes.

Commit 03a50d8f7d872b6ef701d12 "lib:util: Check memset_s() error
code in talloc_keep_secret_destructor()" (Aug-2022) added a check
for error return from memset_s().  This is the only place in whole
codebase which bothers about doing this.  But I've difficult time
figuring out the intention.  Was there a real case when this code
path is actually executed?

Commit 7658c9bf0a9c99e3f200571 "lib:crypto: Remove redundant array
zeroing" (Nov-2023) removed the OTHER line from the two lines used
to zero memory in here.  Initially the code used both memset_s()
*and* ZERO_ARRAY_LEN(), the former has been removed.  This change
removes the other - memset_s(), reintroducing ZERO_ARRAY_LEN().
Here however, it's probably better to use BURN_PTR instead of
ZERO_ARRAY - in this place and a few lines above.

Commit 8dddea2ceda40f2365bd6b1 "lib:talloc: Use memset_s() to avoid
the call gets optimized out" (Feb-2024) is a recent commit which
introduces memset_s().  However, it does not seem like it makes
any difference whatsoever for a testsuite, or that it actually
needs to clean up the memory to begin with.

We've quite an assortment of all this memory zeroing stuff.  Also
it is repeated in replace.h and memory.h (two sets in these files
are different but has big intersection).  I'd say, to fix this mess,
things from replace.h should be removed in favour of memory.h, and
necessary includes added, but this is for the next time.  We also
have lots of direct usages of memset_s() in heimdal code.

Cc: Joseph Sutton 
Signed-off-by: Michael Tokarev 
Reviewed-by: Andreas Schneider 
Reviewed-by: Pavel Filipenský

lib:cmdline: Load network interfaces in _samba_cmdline_load_config_s4()

2024-08-04T00:32:39+00:00

This makes the samba.tests.domain_backup tests start working again when
they are run standalone. Without the load_interfaces() call,
smb_sysvol_conn() fails to make a connection to the sysvol share.

Signed-off-by: Jo Sutton 
Reviewed-by: Douglas Bagnall

lib:cmdline: Fix code spelling

2024-08-04T00:32:39+00:00

Signed-off-by: Jo Sutton 
Reviewed-by: Douglas Bagnall

cmdline:burn: list commands to always burn; warn on unknown

2024-07-10T06:28:08+00:00

We burn arguments to all unknown options containing "pass" (e.g.
"--passionate=false") in case they are a password option, but is bad
in the case where the unknown option takes no argument but the next
option *is* a password (like "--overpass --password2 barney". In that
case "--password2" would be burnt and not "barney".

The burning behaviour doesn't change with this commit, but users will now
see an error message explaining that the option was unknown. This is not
so much aimed at end users -- for who an invalid option will hopefully
lead to --help like output -- but to developers who add a new "pass"
option.

This also slightly speeds up the processing of known password options,
which is a little bit important because we are in a race to replace the
command line in /proc before an attacker sees it.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15674

Signed-off-by: Douglas Bagnall 
Reviewed-by: Jo Sutton 

Autobuild-User(master): Douglas Bagnall 
Autobuild-Date(master): Wed Jul 10 06:28:08 UTC 2024 on atb-devel-224

cmdline:burn: add a note about short option combinations

2024-07-03T01:35:31+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15674

Signed-off-by: Douglas Bagnall 
Reviewed-by: Jo Sutton

cmdline:burn: explicitly burn --username

2024-07-03T01:35:31+00:00

This is the long form of -U in samba-tool.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Jo Sutton

cmdline:burn: use allowlist to ensure more passwords burn

2024-07-03T01:35:31+00:00

We treat any option containing 'pass' with suspicion, unless we know it
is OK.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15674

Signed-off-by: Douglas Bagnall 
Reviewed-by: Jo Sutton