samba.git/lib/dbwrap, branch talloc-2.3.0

lib/dwrap: Fix 'Null pointer passed as an argument to a 'nonnull' parameter '

2019-06-26T10:30:23+00:00

Fixes:

lib/dbwrap/dbwrap.c:645:4: warning: Null pointer passed as an argument to a 'nonnull' parameter <--[clang]
                        memcpy(p, dbufs[i].dptr, thislen);

Signed-off-by: Noel Power 
Reviewed-by: Gary Lockyer

lib/dbwrap: clang: Fix 'all argument is an uninitialized value'

2019-06-26T10:30:23+00:00

Fixes:

lib/dbwrap/dbwrap.c:533:4: warning: 2nd function call argument is an uninitialized value <--[clang]
                        dbwrap_lock_order_unlock(db, lockptr);
                        ^

Signed-off-by: Noel Power 
Reviewed-by: Gary Lockyer

Fix ubsan null pointer passed as argument 2

2019-05-27T01:29:48+00:00

Fix ubsan warning null pointer passed as argument 2 when the source
pointer is NULL.  The calls to memcpy are now guarded by an
if (len > 0)

Signed-off-by: Gary Lockyer 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Gary Lockyer 
Autobuild-Date(master): Mon May 27 01:29:48 UTC 2019 on sn-devel-184

dbwrap: Adapt tdb_data_buf's overflow handling to modern conventions

2019-05-08T16:33:25+00:00

This is the way we do it right now, avoid confusion why "tmp" might be
needed

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

dbwrap: Fix tdb_data_buf()

2019-05-08T16:33:25+00:00

IIRC there are platforms that don't like memcpy() with len=0.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

dbwrap_tdb: Avoid double-call to talloc_get_type_abort

2018-09-14T05:49:13+00:00

We've already retrieved "ctx" in the callers of db_tdb_fetch_locked_internal().

Signed-off-by: Volker Lendecke 
Reviewed-by: Ralph Boehme

dbwrap_tdb: use struct initializer

2018-09-12T20:25:19+00:00

This ensures all struct members are implicitly initialized.

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

dbwrap_tdb: move a function call out of an if condition

2018-09-12T20:25:19+00:00

At least for me this improves readability somewhat. No change in
behaviour.

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

dbwrap: Remove a pointless "return;"

2018-09-07T15:26:18+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Ralph Boehme

dbwrap: Fix a typo

2018-08-17T16:25:08+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 
Reviewed-by: Rowland Penny