<feed xmlns='http://www.w3.org/2005/Atom'>
<title>samba.git/lib/dbwrap, branch talloc-2.3.1</title>
<subtitle>Unnamed repository; edit this file 'description' to name the repository.</subtitle>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/'/>
<entry>
<title>dbwrap_tdb: Avoid a use of talloc_stackframe()</title>
<updated>2019-11-06T20:36:34+00:00</updated>
<author>
<name>Volker Lendecke</name>
<email>vl@samba.org</email>
</author>
<published>2019-10-16T13:27:49+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=d6223677bfded0aed659df4a78f318ffc180003c'/>
<id>d6223677bfded0aed659df4a78f318ffc180003c</id>
<content type='text'>
For really large keys (that probably don't exist), use dump_data()

Signed-off-by: Volker Lendecke &lt;vl@samba.org&gt;
Reviewed-by: Jeremy Allison &lt;jra@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
For really large keys (that probably don't exist), use dump_data()

Signed-off-by: Volker Lendecke &lt;vl@samba.org&gt;
Reviewed-by: Jeremy Allison &lt;jra@samba.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>lib: Allow a 4th lock order</title>
<updated>2019-09-17T22:49:39+00:00</updated>
<author>
<name>Volker Lendecke</name>
<email>vl@samba.org</email>
</author>
<published>2019-09-15T09:56:25+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=ded3f91d80763edfab242a48baa834e669e16ed5'/>
<id>ded3f91d80763edfab242a48baa834e669e16ed5</id>
<content type='text'>
We will have another tdb soon

Signed-off-by: Volker Lendecke &lt;vl@samba.org&gt;
Reviewed-by: Jeremy Allison &lt;jra@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We will have another tdb soon

Signed-off-by: Volker Lendecke &lt;vl@samba.org&gt;
Reviewed-by: Jeremy Allison &lt;jra@samba.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>dbwrap: Initialize state in dbwrap_delete()</title>
<updated>2019-09-10T23:14:31+00:00</updated>
<author>
<name>Volker Lendecke</name>
<email>vl@samba.org</email>
</author>
<published>2019-08-23T15:47:47+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=92c2a723b278fb0338248bfb1fd1c1f4b90dce2b'/>
<id>92c2a723b278fb0338248bfb1fd1c1f4b90dce2b</id>
<content type='text'>
Probably not required, but looks safer and gives static checkers less
reason to complain about potentially uninitialized variable reads

Signed-off-by: Volker Lendecke &lt;vl@samba.org&gt;
Reviewed-by: Jeremy Allison &lt;jra@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Probably not required, but looks safer and gives static checkers less
reason to complain about potentially uninitialized variable reads

Signed-off-by: Volker Lendecke &lt;vl@samba.org&gt;
Reviewed-by: Jeremy Allison &lt;jra@samba.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>lib: Remove an obsolete comment</title>
<updated>2019-09-10T23:14:31+00:00</updated>
<author>
<name>Volker Lendecke</name>
<email>vl@samba.org</email>
</author>
<published>2019-09-05T15:25:07+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=b86df6d0591d7d8f3c08d0fe0975839ba00c342c'/>
<id>b86df6d0591d7d8f3c08d0fe0975839ba00c342c</id>
<content type='text'>
At least as of 2ac9d0afa66 ctdb does not care about db prios anymore

Signed-off-by: Volker Lendecke &lt;vl@samba.org&gt;
Reviewed-by: Jeremy Allison &lt;jra@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
At least as of 2ac9d0afa66 ctdb does not care about db prios anymore

Signed-off-by: Volker Lendecke &lt;vl@samba.org&gt;
Reviewed-by: Jeremy Allison &lt;jra@samba.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>lib: Micro-optimization for db_tdb_do_locked()</title>
<updated>2019-08-19T23:14:38+00:00</updated>
<author>
<name>Volker Lendecke</name>
<email>vl@samba.org</email>
</author>
<published>2019-08-13T12:43:08+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=58b5bfba11a66d250267efe901dfba76f82005f8'/>
<id>58b5bfba11a66d250267efe901dfba76f82005f8</id>
<content type='text'>
We don't need the tdb lock for the talloc_free(buf) anymore

Signed-off-by: Volker Lendecke &lt;vl@samba.org&gt;
Reviewed-by: Ralph Böhme &lt;slow@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We don't need the tdb lock for the talloc_free(buf) anymore

Signed-off-by: Volker Lendecke &lt;vl@samba.org&gt;
Reviewed-by: Ralph Böhme &lt;slow@samba.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>lib/dwrap: Fix 'Null pointer passed as an argument to a 'nonnull' parameter '</title>
<updated>2019-06-26T10:30:23+00:00</updated>
<author>
<name>Noel Power</name>
<email>noel.power@suse.com</email>
</author>
<published>2019-06-14T13:40:28+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=fd17d50f7cb8747c66e64e788bbd45212410d9c7'/>
<id>fd17d50f7cb8747c66e64e788bbd45212410d9c7</id>
<content type='text'>
Fixes:

lib/dbwrap/dbwrap.c:645:4: warning: Null pointer passed as an argument to a 'nonnull' parameter &lt;--[clang]
                        memcpy(p, dbufs[i].dptr, thislen);

Signed-off-by: Noel Power &lt;noel.power@suse.com&gt;
Reviewed-by: Gary Lockyer &lt;gary@catalyst.net.nz&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fixes:

lib/dbwrap/dbwrap.c:645:4: warning: Null pointer passed as an argument to a 'nonnull' parameter &lt;--[clang]
                        memcpy(p, dbufs[i].dptr, thislen);

Signed-off-by: Noel Power &lt;noel.power@suse.com&gt;
Reviewed-by: Gary Lockyer &lt;gary@catalyst.net.nz&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>lib/dbwrap: clang: Fix 'all argument is an uninitialized value'</title>
<updated>2019-06-26T10:30:23+00:00</updated>
<author>
<name>Noel Power</name>
<email>noel.power@suse.com</email>
</author>
<published>2019-06-14T13:36:31+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=37add5c8ce705f9a2d0ab77d6ef07885d72463c7'/>
<id>37add5c8ce705f9a2d0ab77d6ef07885d72463c7</id>
<content type='text'>
Fixes:

lib/dbwrap/dbwrap.c:533:4: warning: 2nd function call argument is an uninitialized value &lt;--[clang]
                        dbwrap_lock_order_unlock(db, lockptr);
                        ^

Signed-off-by: Noel Power &lt;noel.power@suse.com&gt;
Reviewed-by: Gary Lockyer &lt;gary@catalyst.net.nz&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fixes:

lib/dbwrap/dbwrap.c:533:4: warning: 2nd function call argument is an uninitialized value &lt;--[clang]
                        dbwrap_lock_order_unlock(db, lockptr);
                        ^

Signed-off-by: Noel Power &lt;noel.power@suse.com&gt;
Reviewed-by: Gary Lockyer &lt;gary@catalyst.net.nz&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix ubsan null pointer passed as argument 2</title>
<updated>2019-05-27T01:29:48+00:00</updated>
<author>
<name>Gary Lockyer</name>
<email>gary@catalyst.net.nz</email>
</author>
<published>2019-05-23T23:00:05+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=412afb2aef100e09eb433b8f0cae064fc2a736b7'/>
<id>412afb2aef100e09eb433b8f0cae064fc2a736b7</id>
<content type='text'>
Fix ubsan warning null pointer passed as argument 2 when the source
pointer is NULL.  The calls to memcpy are now guarded by an
if (len &gt; 0)

Signed-off-by: Gary Lockyer &lt;gary@catalyst.net.nz&gt;
Reviewed-by: Andreas Schneider &lt;asn@samba.org&gt;

Autobuild-User(master): Gary Lockyer &lt;gary@samba.org&gt;
Autobuild-Date(master): Mon May 27 01:29:48 UTC 2019 on sn-devel-184
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix ubsan warning null pointer passed as argument 2 when the source
pointer is NULL.  The calls to memcpy are now guarded by an
if (len &gt; 0)

Signed-off-by: Gary Lockyer &lt;gary@catalyst.net.nz&gt;
Reviewed-by: Andreas Schneider &lt;asn@samba.org&gt;

Autobuild-User(master): Gary Lockyer &lt;gary@samba.org&gt;
Autobuild-Date(master): Mon May 27 01:29:48 UTC 2019 on sn-devel-184
</pre>
</div>
</content>
</entry>
<entry>
<title>dbwrap: Adapt tdb_data_buf's overflow handling to modern conventions</title>
<updated>2019-05-08T16:33:25+00:00</updated>
<author>
<name>Volker Lendecke</name>
<email>vl@samba.org</email>
</author>
<published>2019-05-03T13:43:35+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=08a31c9092b808a49ecdf92e8cc0ae9132ba6645'/>
<id>08a31c9092b808a49ecdf92e8cc0ae9132ba6645</id>
<content type='text'>
This is the way we do it right now, avoid confusion why "tmp" might be
needed

Signed-off-by: Volker Lendecke &lt;vl@samba.org&gt;
Reviewed-by: Jeremy Allison &lt;jra@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This is the way we do it right now, avoid confusion why "tmp" might be
needed

Signed-off-by: Volker Lendecke &lt;vl@samba.org&gt;
Reviewed-by: Jeremy Allison &lt;jra@samba.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>dbwrap: Fix tdb_data_buf()</title>
<updated>2019-05-08T16:33:25+00:00</updated>
<author>
<name>Volker Lendecke</name>
<email>vl@samba.org</email>
</author>
<published>2019-05-03T13:42:42+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=30abea8815113045b7ee075352c415fe176a48fe'/>
<id>30abea8815113045b7ee075352c415fe176a48fe</id>
<content type='text'>
IIRC there are platforms that don't like memcpy() with len=0.

Signed-off-by: Volker Lendecke &lt;vl@samba.org&gt;
Reviewed-by: Jeremy Allison &lt;jra@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
IIRC there are platforms that don't like memcpy() with len=0.

Signed-off-by: Volker Lendecke &lt;vl@samba.org&gt;
Reviewed-by: Jeremy Allison &lt;jra@samba.org&gt;
</pre>
</div>
</content>
</entry>
</feed>
