samba.git/lib/dbwrap, branch talloc-2.3.3

dbwrap: Remove "db_context->try_fetch_locked()" fn pointer

2021-06-04T16:47:34+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

dbwrap: Remove unused dbwrap_try_fetch_locked()

2021-06-04T16:47:34+00:00

Small simplification, this has not been used since 2014 when the
notifyd went in. Can easily be added if needed again.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

dbwrap_rbt: support TDB_INSERT and TDB_MODIFY store flags

2020-06-10T19:08:40+00:00

These flags provide insert-new and overwrite-existing record semantics
respectively.

Signed-off-by: David Disseldorp 
Reviewed-by: Jeremy Allison

dbwrap: Make dbwrap_lock_order_[un]lock() public

2020-05-15T00:48:32+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

dbwrap: Simplify dbwrap_lock_order_[un]lock()

2020-05-15T00:48:32+00:00

Directly pass the database name and lock order to the core functions,
avoid passing struct db_context.

In the next steps these functions will become public: locking.tdb will
be based on g_lock.c to avoid holding a tdb-level locking.tdb mutex
while doing complex file system operations like unlink() which can
take ages on FAT for example.

This means that g_lock.c will participate in the dbwrap lock order
protection and needs access to dbwrap_lock_order_[un]lock() without
providing a direct db_context.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

dbwrap: Don't set rec->value in dbwrap_do_locked()

2019-11-22T23:57:46+00:00

We pass that via the callback now

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

dbwrap: Protect against invalid db_record->value

2019-11-22T23:57:46+00:00

After dbwrap_record_storev()/delete(), dbwrap_record_get_value()
information is stale. Assert on the attempt to re-fetch data after it
became stale. This can't protect against someone copying the result
from dbwrap_record_get_value() somewhere else, but it's better than
nothing.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

dbwrap: Pass "value" to dbwrap_do_locked() callback

2019-11-22T23:57:46+00:00

I want to reduce dbwrap_record_get_value(). It makes the caller believe it can
make a copy of the TDB_DATA returned and that the value remains constant. It's
not, as you can always do a dbwrap_record_store().

This patch removes one requirement for getting the value out of a
db_record via dbwrap_record_get_value(). You can still make a copy, but from an
API perspective to me it's more obvious that "value" as a parameter to the
callback has a limited lifetime.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

dbwrap_tdb: Return correct error from db_tdb_storev()

2019-11-22T23:57:46+00:00

Don't lose information to NT_STATUS_UNSUCCESSFUL

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

dbwrap_tdb: Avoid includes.h

2019-11-22T23:57:46+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison