samba.git/lib/fuzzing, branch master

libsmb: Remove "source3/libsmb/libsmb.h"

2025-06-16T15:05:32+00:00

libsmb.h added ads_status.h and cli_smb2_fnum.h. Only few users need
either.

Signed-off-by: Volker Lendecke 
Reviewed-by: Ralph Boehme

wafsamba: Set env variables before calling command

2025-05-16T09:33:41+00:00

Old optparse handling in third_party/waf/waflib/Options.py would process
leftover arguments and distinguish between env var overrides and
commands. In waf 2.1.5 Options.py no longer will do this and we can see
this with config command like (from fuzz job)

./configure.developer -C --without-gettext --enable-debug --enable-developer --enable-libfuzzer --address-sanitizer --disable-warnings-as-errors --abi-check-disable --fuzz-target-ldflags=-Wl,--disable-new-dtags  --nonshared-binary=ALL --enable-afl-fuzzer --with-prometheus-exporter LINK_CC=

failing like below

'configure' finished successfully (1m11.100s)

==> /builds/samba-team/devel/samba/samba-fuzz.stderr <==
No function 'LINK_CC=' defined in /builds/samba-testbase/samba-fuzz/wscript
2025-05-02 08:58:21,615 samba-fuzz: [fuzzers-build] failed 'OUT=/builds/samba-testbase/prefix/samba-fuzz LIB_FUZZING_ENGINE= SANITIZER=address CXX= CFLAGS= ADDITIONAL_LDFLAGS='-fuse-ld=bfd' ./lib/fuzzing/oss-fuzz/build_samba.sh --enable-afl-fuzzer --with-prometheus-exporter' with status 1

Now we should just use the needed env directly e.g. for example above you
should call configure as below

LINK_CC= ./configure.developer -C --without-gettext --enable-debug --enable-developer --enable-libfuzzer --address-sanitizer --disable-warnings-as-errors --abi-check-disable --fuzz-target-ldflags=-Wl,--disable-new-dtags  --nonshared-binary=ALL --enable-afl-fuzzer --with-prometheus-exporter

This patch adjusts some documentation and a build script to reflect
this change.

Signed-off-by: Noel Power 
Reviewed-by: Andreas Schneider 
Reviewed-by: Stefan Metzmacher

fuzzing: fix fuzz_stable_sort_r_unstable comparison

2024-05-31T05:29:08+00:00

Credit to OSS-Fuzz.

REF: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=69176

Signed-off-by: Douglas Bagnall 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Volker Lendecke 
Autobuild-Date(master): Fri May 31 05:29:08 UTC 2024 on atb-devel-224

lib/fuzzing: add fuzz_strncasecmp_ldb

2024-05-22T23:12:32+00:00

As well as checking for the usual overflows, this asserts that
strncasecmp_ldb is always transitive, by splitting the input into 3
pieces and comparing all pairs.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

lib/fuzzing: fuzz_stable_sort_r_unstable tries to catch overrun

2024-05-22T04:23:29+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

lib:fuzzing: Fix undefined shift

2024-05-16T02:11:36+00:00

../../lib/fuzzing/fuzz_stable_sort_r_unstable.c:47:22: runtime error: left shift of negative value -34

Signed-off-by: Jo Sutton 
Reviewed-by: Andrew Bartlett

lib:fuzzing: Remove unused variable

2024-05-16T02:11:36+00:00

Signed-off-by: Jo Sutton 
Reviewed-by: Andrew Bartlett

lib/fuzzing: add fuzz_stable_sort_r_unstable

2024-05-07T23:25:35+00:00

This should find out how well stable_sort copes with an unstable
non-transitive comparison function.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

lib: Give lib/util/util_file.c its own header file

2024-04-16T23:51:45+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Martin Schwenke

lib/fuzzing/decode_ndr_X_crash: guess the pipe from filename

2024-04-10T22:56:33+00:00

Usually we are dealing with a filename that tells you what the pipe is,
and there is no reason for this debug helper not to be convenient

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15625

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett