samba.git/lib/fuzzing, branch talloc-2.4.2

fuzz: allow max size conditional ACE round-trip failure

2023-12-22T00:51:13+00:00

The encoder, being cautious not to overstep the arbitrary 10000 byte
boundary, might not encode an exactly 10000 byte condition. This
is an off-by-one, but in the safe direction.

Credit to OSS-Fuzz.

REF: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=65118

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Fri Dec 22 00:51:13 UTC 2023 on atb-devel-224

lib/fuzzing: Fix code spelling

2023-12-08T02:28:33+00:00

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

libcli/security: Optionally disallow device‐specific attributes and operators where they are not applicable

2023-11-09T08:00:30+00:00

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

librpc:ndr: Introduce ‘ndr_flags_type’ type

2023-11-01T20:10:45+00:00

Instead of ‘int’ or ‘uint32_t’, neither of which convey much meaning,
consistently use a newly added type to hold NDR_ flags.

Update the NDR 4.0.0 ABI.

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

librpc:ndr: Introduce ‘libndr_flags’ type

2023-11-01T20:10:45+00:00

The LIBNDR_FLAG_ namespace is getting dangerously full, with only a
single flag value (1 << 9) remaining for use. After that flag is put
into use, we won’t be able to add any new flags without increasing the
flag width to 64‐bit.

Up to now we’ve used a haphazard mix of int, unsigned, and uint32_t to
store these flags. Introduce a new type, ‘libndr_flags’, to be used
consistently to hold LIBNDR flags. If in the future we find we need to
move to 64‐bit flags, this type gives us an opportunity to do that.

Bump the NDR version to 4.0.0 — an major version increment, for we’re
changing the function ABI and adding the new symbol
ndr_print_libndr_flags.

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

lib/fuzzing: Fix code spelling

2023-10-25T22:23:37+00:00

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

fuzzing: fuzz_sddl_parse forgives bad utf-8

2023-09-26T23:45:36+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

lib/fuzzing: fuzz_sddl_parse: allow non-round-trip with long strings

2023-09-26T23:45:36+00:00

There is a borderline case where a conditional ACE unicode string
becomes longer than the SDDL parser wants to handle when control
characters are given canonical escaping. This can make the round trip
fail, but it isn't really a problem.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

lib/fuzzing: adjust access-check seed patch

2023-09-26T23:45:35+00:00

Now that access_check.c includes headers for conditional ACEs, the patch
should take that into account.

Also, we check for a talloc failure.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

lib/fuzzing: fuzz_conditional_ace_blob

2023-09-26T23:45:35+00:00

This parses the blob as a conditional ACE, and if possible tries
decompiling it into SDDL.

There are not many round-trip assertions we can honestly make, but we
keep the trip going as long as possible, in case it reveals anything.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett